Node: Destructuring Assignment Parse Error - works in Chrome & Safari but not Node

[shanebdavis]

• Version: v6.9.5
• Platform: Darwin Honor.local 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64
• Subsystem: parser

This source: a=b=1;((a + 1), {c} = b)

• Works in Chrome 56.0.2924.87
• Works in Safari 10.0.3 (12602.4.8)
• Fails to parse in Node

Quick command-line test:

• echo "a=b=1;((a + 1), {c} = b)" | node

These slight variations DO work in node:

• a=b=1;((a), {c} = b)
• a=b=1;((a + 1), ({c} = b))

[shanebdavis]

It also works in: Babel 6.23.1

[addaleax]

@shanebdavis Fwiw, it also works in Node 7.x, which means it was likely fixed during a V8 upgrade.

/cc @nodejs/v8

[shanebdavis]

@addaleax Thanks! That makes sense. I was wondering why it worked in Chrome and not Node.

Is 6.x scheduled to get V8 updates?

[addaleax]

Is 6.x scheduled to get V8 updates?

Not regularly. I think the process for these cases is to look for which commit(s) in V8 fixed the problem, see if is feasible to apply them to the old V8 branch and then cherry-pick them back.

[Fishrock123]

Eh I suppose we can keep the label on it if backporting is at all viable.

[targos]

I Identified https://github.com/v8/v8/commit/dfb8d3331e7cb2c3e67ef820cbcb6cfbae7159e5 as the commit that fixes it using git bisect.

[targos]

https://github.com/nodejs/node/pull/11483

[targos]

Fixed by https://github.com/nodejs/node/commit/d0e934f028f9026baab58399c5e0a6d7d7275e22