Node: doc: update collaborator_guide to mention core-validate-commit

Created on 27 Oct 2016  路  8Comments  路  Source: nodejs/node

Subsystem: doc

鈥hould mention @evanlucas ' https://github.com/evanlucas/core-validate-commit as a helpful tool in validating commit messages.

It could be helpful even for contributors also.

doc meta

All 8 comments

doc/onboarding.md too

@mscdex I'd like to work on this issue. I'm a newbie in Open Source, should I know anything before I get started?
Thanks! :)

@Tanuja-Sawant read https://github.com/nodejs/node/blob/master/CONTRIBUTING.md and give it a go, thanks!

Okay, thanks @sam-github
Can you tell me where do I make changes that will eventually modify https://nodejs.org/en/get-involved/development/#landing-pull-requests
Thanks! :)

@Tanuja-Sawant You want the nodejs.org repo, that section is: https://github.com/nodejs/nodejs.org/blob/c8baa35c5b752fa7151da4ea22fab0b493f6a997/locale/en/get-involved/development.md#landing-pull-requests

It looks like that page is pretty similar to some of the stuff in https://github.com/nodejs/node/blob/add885416f38020f84b544b3cc0be28d6cf59bdc/COLLABORATOR_GUIDE.md#landing-pull-requests , they may well have got out of sync and need updating.

@gibfahn Oh I just saw your comment after creating a PR for other doc files. The page you referred me to is included in the code of nodejs/nodejs.org directory. Will it be apt to make changes of that file and make a PR here -in nodejs/node?
Thanks so much!

@Tanuja-Sawant You'll need to fork nodejs/nodejs.org and open a separate PR for changes to that Github repo, unfortunately Github needs 1 PR per repo.

So you'll end up with two Pull Requests, I'd include a link to the other Pull Request and to this issue in each Pull Request.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

akdor1154 picture akdor1154  路  3Comments

danielstaleiny picture danielstaleiny  路  3Comments

filipesilvaa picture filipesilvaa  路  3Comments

sandeepks1 picture sandeepks1  路  3Comments

dfahlander picture dfahlander  路  3Comments