Node: Should switch classes to define class and fix name anonymous functions?

[fundon]

I saw some PRs that fix name anonymous functions.

Should switch to below way?

/lib/stream.js

class Stream extends EE {
  constructor () {
    super()
  }

  pipe () {
    // ...
  }
}

[Fishrock123]

Only if it is already a class. If not, please don't. (The large change will likely make backporting far more difficult.)

[addaleax]

The change would also break creation of objects without new.

[fundon]

@addaleax

creation of objects

module.exports = {

  pipe () {
  },

  end () {
  }

}

[addaleax]

@fundon Stream() wouldn’t work because it’s a class :/

[fundon]

@addaleax Do you talk about this?

var stream = require('stream')
undefined
> stream.Stream()
undefined

[addaleax]

@fundon If you turn Stream into a proper class, that breaks things like Stream.call(this); in the Writable constructor. You can somewhat work around that but once you’re at the double inheritance of Duplexes, things get really tricky…