Node: child_process: outdated comment

Created on 4 Oct 2016  路  4Comments  路  Source: nodejs/node

  • Version: all
  • Platform: n/a
  • Subsystem: child_process

There is an outdated comment in lib/child_process.js that needs to be updated to better reflect what the code beneath it has been doing for some time now. Instead of commandeering stdin for IPC usage, a separate fd is actually used for IPC.

child_process

All 4 comments

I'm Tanuja Sawant and would like to work on this issue as part of one of my initial contributions to Node.js for the Outreachy Internship. Would you kindly assign this issue to me or should I go ahead and make a pull request?
Thanks so much!

Hi again!
Please correct me if I'm wrong, the comment

// Leave stdin open for the IPC channel. stdout and stderr should be the
// same as the parent's if silent isn't set.

can be replaced by

// Use a separate fd=4 for IPC channel. Inherit stdin, stdout and stderr 
// from the parent if silent isn't set.

@Tanuja-Sawant Can you open a pull request? Collaborators will review it and suggest changes if necessary.

pulled request in #8988

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cong88 picture cong88  路  3Comments

danialkhansari picture danialkhansari  路  3Comments

mcollina picture mcollina  路  3Comments

vsemozhetbyt picture vsemozhetbyt  路  3Comments

Icemic picture Icemic  路  3Comments