Node: Punycode fails for Russian(Cyrillic)

[ALJCepeda]

• Version: v7.0.0-pre
• Platform: Linux vagrant 4.4.0-31-generic #50-Ubuntu
• Subsystem:

REF #4640

There's a portion of the test that's commented out because it fails, it was done in 0e19476595729c850f07befea93e864822cd8459 10d4bd8. The comment suggests there's a bug in the RFC.

Is this something that can be fixed? Or should that portion be deleted?

[gibfahn]

Just to add the info from #4640:

Test:
parallel/test-punycode.js:

Comment:

// (I) Russian (Cyrillic)
/* XXX disabled, fails - possibly a bug in the RFC
'b1abfaaepdrnnbgefbaDotcwatmq2g4l':
'\u043F\u043E\u0447\u0435\u043C\u0443\u0436\u0435\u043E\u043D\u0438' +

The comment was actually added in https://github.com/nodejs/node/commit/10d4bd8266f7983929b57f6394fb5d99d60fa711 (but the file was moved in https://github.com/nodejs/node/commit/0e19476595729c850f07befea93e864822cd8459).

I think the original issue for this was: https://github.com/nodejs/node-v0.x-archive/issues/2072

cc/ @bnoordhuis as the original comment author.

[gibfahn]

This comment suggests the error was a typo: https://github.com/nodejs/node-v0.x-archive/issues/2072#issuecomment-2707215

[jasnell]

We have recently switched the punycode implementation to use the one provided by the ICU module by default. It is possible that whatever the original issue was here, it may be resolved. I'll see about testing it later on today.

[bnoordhuis]

It was a bug in the spec's test suite. The fix is trivial, the capital D in the input should be lower-cased.

diff --git a/test/parallel/test-punycode.js b/test/parallel/test-punycode.js
index 4292754..abd495e 100644
--- a/test/parallel/test-punycode.js
+++ b/test/parallel/test-punycode.js
@@ -62,12 +62,10 @@ var tests = {
       '\uC744\uAE4C',

   // (I) Russian (Cyrillic)
-  /* XXX disabled, fails - possibly a bug in the RFC
-  'b1abfaaepdrnnbgefbaDotcwatmq2g4l':
+  'b1abfaaepdrnnbgefbadotcwatmq2g4l':
       '\u043F\u043E\u0447\u0435\u043C\u0443\u0436\u0435\u043E\u043D\u0438' +
       '\u043D\u0435\u0433\u043E\u0432\u043E\u0440\u044F\u0442\u043F\u043E' +
       '\u0440\u0443\u0441\u0441\u043A\u0438',
-  */

   // (J) Spanish: Porqu<eacute>nopuedensimplementehablarenEspa<ntilde>ol
   'PorqunopuedensimplementehablarenEspaol-fmd56a':