Node-ytdl-core: Random ECONNRESET

Created on 10 Jul 2016 · 52Comments · Source: fent/node-ytdl-core

Hello,

I've had a issue with this library ever since I started to use it. I basically pass the ytdl stream into ffmpeg to extract the audio from the video. Sometimes the stream crashes with an ECONNRESET, and i have no idea why.

Stacktrace:
Error: read ECONNRESET at exports._errnoException (util.js:1007:11) at TLSWrap.onread (net.js:563:26)

bug

Source

MergHQ

👍5

Most helpful comment

Hey guys, he's actually currently working on a fix for it so we can stop confirming this, as the PR #128 should fix it.

FireController1847 on 2 Apr 2017

👍3

All 52 comments

Do you have an example where this happens?

Is the example here similar?

fent on 12 Jul 2016

@fent This is where it happens.

MergHQ on 12 Jul 2016

Got that error, too. No specific Video or something just happened - and nothing can be downloaded.

mh4ck on 12 Jul 2016

There's no need to call ytdlStream.end() btw, .destroy() should be enough in theory.

fent on 21 Jul 2016

Have been getting this error for a few months now...

amishshah on 24 Oct 2016

I have noticed that using the audioonly flag actually helps. Doesn't throw that error so often anymore.

MergHQ on 24 Oct 2016

Does this happen at the start of the download, middle, end?

fent on 25 Oct 2016

Mainly the end, around 15 seconds before the end of the video

amishshah on 25 Oct 2016

Happening to me too.

ghost on 1 Jan 2017

I have the same issue, but it happens to me in the middle / first half of the video

Brain-Gamer on 22 Feb 2017

I've noticed the issue occur sporadically, sometimes I can go a few videos with nothing while others cut off half way or near the end of playback.

derekmartinez18 on 24 Feb 2017

Yeah I think it is pretty much random. But for me it's more often at the beginning of a video (most times)

Brain-Gamer on 24 Feb 2017

Can also report this issue. Happens randomly through playback, just started happening recently. I've always had this with connection loss, but the bot is currently not losing connection and it's just happening while the song was playing fine. Seems to be more common in the past few days.

FireController1847 on 9 Mar 2017

@fent People are saying it could be due to the fact you are downloading videos "unofficially", or without a developer key.

FireController1847 on 9 Mar 2017

👍2 😕1

Same over here, random but mostly after the middle of the video

TinyMan on 17 Mar 2017

I'm still having issues with this in #128 even though the pull marked it as fixed.

OzairP on 22 Mar 2017

I can also confirm that this issue is still occurring at roughly the same frequency.

derekmartinez18 on 23 Mar 2017

I can confirm as well.

FireController1847 on 23 Mar 2017

Can confirm that this is still occurring about halfway through the stream.

Scott41 on 30 Mar 2017

I almost always get this error at 1:23 when I try to stream this video: https://www.youtube.com/watch?v=iRSuh7OVdDs

This error occurs for me with every video longer than ~1min, but I found that that video throws the error fairly consistently.

Ghoulean on 1 Apr 2017

Can confirm, this is still occurring.

exception on 2 Apr 2017

Can also confirm.

Phineas on 2 Apr 2017

Hey guys, he's actually currently working on a fix for it so we can stop confirming this, as the PR #128 should fix it.

FireController1847 on 2 Apr 2017

👍3

Related to this issue. Was getting the reset error, but I manually pulled the new commits (used the default npm installer previously). Reconnection seems to not work correctly, the video doesn't end correctly. Audio goes straight to the discord voice connector. Used this snippet of code (and modified) you provided on another thread

var ytdl = require('..');
var stream = ytdl('https://www.youtube.com/watch?v=6ySOK70gFPk');


var size;
stream.on('response', function(res) {
  size = res.headers['content-length'];
  console.log('size', size);
});

var dataEmitted = 0;
stream.on('data', function(chunk) {
  dataEmitted += chunk.length;
  console.log('on data', chunk.length, dataEmitted);
});

stream.on('end', function() {
  console.log('emitted', dataEmitted);
});

This was the result.
log.txt
The video that was causing it: https://www.youtube.com/watch?v=aatr_2MstrI

ibexes on 5 Apr 2017

@ibexes did u try with the latest reg release(v11)?
u should also add a listener for the error event if ur having problems...

TimeForANinja on 5 Apr 2017

@TimeForANinja I believe so, yes. Previously it wouldn't even reconnect, it'd just throw the error. Now it just doesn't reconnect properly.

ibexes on 5 Apr 2017

Try again with the master branch please
ran perfectly fine for me with reconnects

TimeForANinja on 5 Apr 2017

@TimeForANinja I do have a listener for errors, there apparently isn't an error and it just hangs at the last line of the log, instead of finishing and giving me an emitted. I'm filtering the stream for audio only if that makes a difference.

I've isolated the code and it runs fine, in a single block. I'm using the stream with the playstream function in discord voice connection, so that could explain why there is an error, but I'm not sure why it hangs. It's only on a few random videos but they seem consistent and stop at the same location. I'm not sure how to recreate the environment in the isolated code since I don't know how the playstream function works exactly. I'll add a timestamp of the log and see the rate.
log.txt

The 'ended' at the end is printed when the discord playstream function has ended.
E: using the master branch, renamed the package something random to make sure it's using it correctly.
E2: when it reconnects, it doesn't seem to reconnect at the correct location with discord.
E3: it doesn't always print ended
E4: 'reason: Stream is not generating quickly enough.' when I logged why playstream ended. Awkward, not really sure how to fix that...

E5:
log.txt emitted at end =/= size at top

ibexes on 5 Apr 2017

Works perfectly on my end. I get 'reason: Stream is not generating quickly enough.' when I reach the end of the video, so no more data can be streamed.

What reasons (if any) do the dispatcher and stream give when they end and/or they throw an error?

Ghoulean on 6 Apr 2017

Not sure if anyone's still working on this, since it was marked closed. I noticed that

// Install discord.js before running this!
const Discord = require('discord.js');
const ytdl    = require('ytdl-core');

const client = new Discord.Client();
client.login('Token here');

client.on('message', message => {
  if (message.content.startsWith('++play')) {
    const voiceChannel = message.member.voiceChannel;
    if (!voiceChannel) {
      return message.reply('Please be in a voice channel first!');
    }
    voiceChannel.join()
      .then(connnection => {
        let stream = ytdl('https://www.youtube.com/watch?v=aatr_2MstrI',{quality:249,filter : 'audioonly'});
        ytdl_debugger(stream,true);
        const dispatcher = connnection.playStream(stream);
        dispatcher.on('end', reason => {
            console.log("reason: "+reason);
          voiceChannel.leave();
        });
      });
  }
});

function ytdl_debugger(stream,debug){
    var size;
    stream.on('response', function(res) {
              size = res.headers['content-length'];
              if(debug) console.log('size', size);
              });

    var dataEmitted = 0;
    stream.on('data', function(chunk) {
              dataEmitted += chunk.length;
              var date = new Date();
              if(debug) console.log(date+': on data', chunk.length, dataEmitted);
              });

    stream.on('end', function() {
              if(debug) console.log('emitted', dataEmitted);
              });
    stream.on('error', function(error) {
              console.log(error);
              });

}

I believe I've isolated it. It dies early if you're getting audio only and when it disconnects. This seems to be because it loads it all at once really quickly. See this log piped from terminal, specifically the time stamps log.txt. It isn't ideal, but a current bypass is to just stream the whole video in a format that isn't wasteful in discord, that seems to work fine. Until (hopefully) a fix?

To anyone also having this problem, you can alternatively hold a buffer of 10 songs or something, well, saving to disk then just playing from file.

ibexes on 7 Apr 2017

From that log:

size 1702823
emitted 1670055

1702823 - 1670055 = 32768

Which is 16384 * 2. It reconnected twice, that must be related.

fent on 8 Apr 2017

Two things.

The inconsistent total emitted vs content-length is due to a bad .unpipe() that I just pushed.

The "Stream is not generating quickly enough." end message is from an error in discord.js, both with the latest v11.0.0 and with latest. If that { end: false } is removed, the stream ends without issues. I'm not too familiar with discord.js, so I'm not sure why the transcoder stdin is kept open there.

There's also an issue opened for that already

fent on 9 Apr 2017

This seems to still be happening to me, where it's cutting the end of the song off.

godleydemon on 23 Apr 2017

@godleydemon Seems fine to me. I've only had some songs fail to load immideatly, but no songs cutting short.