Node-sqlite3: Publishing Electron binaries to S3 bucket

[DenisCarriere]

I've built a "mono" repo (sqlite3-offline) of all the sqlite3 binaries which are pulled directly from the S3 bucket url filepath.

The update-binaries.js script iterates over the following parameters:

const MODULES = [46, 47, 48, 50, 51, 53, 57] // process.versions.modules
const PLATFORMS = ['darwin', 'linux', 'win32'] // process.platform
const ARCHS = ['ia32', 'x64', 'x86'] // process.arch

Missing Binaries

Noticed a few binaries were missing:

• [ ] Electron (modules 50 & 53 ** might be more)
• [ ] Linux (32 bit x86)

Publishing these binaries using the .travis.yml would definitely help out all the following issues and we could then bundle these binaries directly in this offline-sqlite library for those folks who have a hard time using sqlite3 with Electron or building cross-platform applications in an offline environment.

Ref: https://github.com/mapbox/node-sqlite3/issues/838 https://github.com/mapbox/node-sqlite3/issues/833 https://github.com/mapbox/node-sqlite3/issues/821 https://github.com/mapbox/node-sqlite3/issues/820 https://github.com/mapbox/node-sqlite3/issues/792 https://github.com/mapbox/node-sqlite3/issues/785 https://github.com/mapbox/node-sqlite3/issues/778 https://github.com/mapbox/node-sqlite3/issues/764 https://github.com/mapbox/node-sqlite3/issues/677

[develar]

You are hero! electron-builder 19.10.0 doesn't pass --build-from-source by default and if sqlite3 will provide prebuilt binaries for electron — it will be very cool and will help a lot of users.

[springmeyer]

Publishing these binaries using the .travis.yml would definitely help out all the following issues

This would be amazing. Someone has already started this at https://github.com/mapbox/node-sqlite3/pull/811. The ideal next step in my mind @DenisCarriere - would be to add support for publishing electron binaries to https://github.com/mapbox/node-cpp-skel/. This is because this module is a sample of best practices - building the support into https://github.com/mapbox/node-cpp-skel first would help us port back to node-sqlite (which is more complicated). Thoughts?

/cc @mapbox/core-tech

[kewde]

Thank you @DenisCarriere.
I was not in the mood to wip up a Windows VM just to compile sqlite3, works flawlessly.