Node-slack-sdk: Strong type api method responses

Created on 15 Mar 2018  路  3Comments  路  Source: slackapi/node-slack-sdk

Description

Hello, I'm continuing my migration for botbuilder-slack to the new 4.x release. Today I realized that the responses from method calls are not type dependent on the method invocation, response type for every api call is Promise<WebAPICallResult>. Is there any plan to support strong typed responses ? I can work on this with my previous typings.

What type of issue is this? (place an x in one of the [ ])

  • [ ] bug
  • [X] enhancement (feature request)
  • [ ] question
  • [ ] documentation related
  • [ ] testing related
  • [ ] discussion

Requirements (place an x in each of the [ ])

  • [X] I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • [X] I've read and agree to the Code of Conduct.
  • [X] I've searched for any related issues and avoided creating a duplicate issue.
typescript enhancement

Most helpful comment

@bilby91 I鈥檓 glad to see your migration continue!

We鈥檙e having a discussion about a few different ways to get richer types in another issue. Specifically, I mentioned exactly what you鈥檙e asking for in point (4) in this comment. I鈥檇 really appreciate your participation in that discussion so we can potentially come up with the steps to get there and divide the work.

All 3 comments

@bilby91 I鈥檓 glad to see your migration continue!

We鈥檙e having a discussion about a few different ways to get richer types in another issue. Specifically, I mentioned exactly what you鈥檙e asking for in point (4) in this comment. I鈥檇 really appreciate your participation in that discussion so we can potentially come up with the steps to get there and divide the work.

Hello @aoberoi !!

I've been looking into the issues and PRs and it seems that there has been some progress on response typings :)

Are they complete by this moment ?

There is a PR open currently adding typing for web api responses. https://github.com/slackapi/node-slack-sdk/pull/1078. We are hoping to land these changes in the next few months.

Was this page helpful?
0 / 5 - 0 ratings