Node-sass: Node 15 Support

[nschonni]

Version 15 is supposed to be released on October 20th, 2020. Few things that should probably happen to make it smoother going forward:

• [ ] Promote the fixups in the v5 branch
• [x] Drop testing on unsupported Node versions (<10)
• [ ] Allow people to try and build on old node version, but show warning that we won't support issues opened for those platforms
• [ ] Hold off 3.6 libsass upgrade for separate major release once there is a major version people can pin to

[nschonni]

@xzyfer I believe the release is expected out today (the 20th). It may just be a matter of restarting the CIs on https://github.com/sass/node-sass/pull/2983 or we might have to wait for AppVeyor for the x86 build

[xzyfer]

Traditionally we have been blocked on appveyor and Travis to add the new node versions.

[xzyfer]

I can build the OSX binaries which will mean we're not blocked on Travis.

[nschonni]

I think OSX/Linux should be fine on the GitHub Actions, since they should upload the binaries. I think the gaps will be:

• [ ] Windows x86 on AppVeyor
• [ ] Apline on GitHub Actions will require a new nodejs/docker-node PR and publish on official-images repo
• [ ] FreeBSD binraries from @saper unless we get the Cirrus CI figured out

Remembered that we're actually fully of Travis now, so we're not waiting for that part anymore

[xzyfer]

I'm not sure I understand the alpine issue. Alpine images are usually
released alongside the Debian images. Are they not suitable?

On Tue, 20 Oct 2020, 4:22 pm Nick Schonning, [e-mail]
wrote:

I think OSX/Linux should be fine on the GitHub Actions, since they should
upload the binaries. I think the gaps will be:

• Windows x86 on AppVeyor
• Apline on GitHub Actions will require a new nodejs/docker-node PR
  and publish on official-images repo
• FreeBSD binraries from @saper https://github.com/saper unless we
  get the Cirrus CI figured out

Remembered that we're actually fully of Travis now, so we're not waiting
for that part anymore

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2965#issuecomment-712597510,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAENSWCXQECKU3YMKO4FC6DSLUNBXANCNFSM4RRHLCVA
.

[nschonni]

We use the Node.js Alpine images from https://github.com/nodejs/docker-node, which will need to release a v15 version. Once a PR is merged there, it creates another PR to https://github.com/docker-library/official-images, which is then merged and built out on their CI to publish to the Docker Hub

[xzyfer]

Sorry I think I'm just out of touch with how the new GitHub checks work.
I'll read up on it.

On Tue, 20 Oct 2020, 4:28 pm Nick Schonning, [e-mail]
wrote:

We use the Node.js Alpine images from
https://github.com/nodejs/docker-node, which will need to release a v15
version. Once a PR is merged there, it creates another PR to
https://github.com/docker-library/official-images, which is then merged
and built out on their CI to publish to the Docker Hub

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2965#issuecomment-712600139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAENSWGCJXBSCFBBSCY6X4DSLUNZJANCNFSM4RRHLCVA
.

[nschonni]

The Alpine stuff is here https://github.com/sass/node-sass/blob/master/.github/workflows/alpine.yml, it pulls and runs on the "official image" for Node.js. Rest of the Actions use the https://github.com/actions/setup-node/ to install a particular version on Node.js

[xzyfer]

I quickly skimmed the action and it looks like it might be using an arch
Linux mode binary. I may still be missing something however

Typically we build the binaries on CentOS for better compatibility across
Linux distributions. Just something we should keep note of incase we start
seeing reports of issues with the binaries.

On Tue, 20 Oct 2020, 4:45 pm Nick Schonning, [e-mail]
wrote:

The Alpine stuff is here
https://github.com/sass/node-sass/blob/master/.github/workflows/alpine.yml,
it pulls and runs on the "official image" for Node.js. Rest of the Actions
use the https://github.com/actions/setup-node/ to install a particular
version on Node.js

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2965#issuecomment-712606620,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAENSWH5BLSAUQ2IMCLRCKLSLUPXFANCNFSM4RRHLCVA
.

[nschonni]

@xzyfer so funny story, looks like AppVeyor is actually OK (for the v15 support in the matrix), but all platforms are failing to read the built binary and failing on the test step 😕

PS: PR for the Alpine docker images is https://github.com/nodejs/docker-node/pull/1372

[wiesson]

I just wanted to mention that yarn did rebuild node-sass for me without any problems (needed to delete node_modules though)

[dhulme]

My build server's docker image (alpine) upgraded to Node 15 and the builds broke because binaries aren't available yet. I've fixed by changing the image to use LTS but would be great to get these binaries out 👍 Thanks!

[nschonni]

@xzyfer I've uploaded the binaries built for https://github.com/sass/node-sass/commit/0648b5a59df693686e745d3690fc73e768200c47 to https://github.com/sass/node-sass/releases/tag/v5.0.0
Here are the ones still missing:

• Windows x86. I'm not finding the artifacts for those on AppVeyor. I think they're supposed to be built on tag, but I'm not seeing them
• Alpine for Node 15. Since the job is failing with the CLI tests, it's not currently uploading that one
• FreeBSD, will need @saper for 14 & 15 ones, but the previous 10, 12 can probably be re-used

Also dropped mention of Linux x86 from the table since it isn't officially supported on any of those Node versions anymore

[xzyfer]

The appveyor build requires a custom build I can kick off later today

[robrich]

Will there be a [email protected] build for Node 15?

[nschonni]

No, it will only be supported in 5 https://github.com/sass/node-sass#node-version-support-policy

[herbievine]

Is there a v5.x?

[bcksmc]

Can we bump the version number for v5 in package.json? It still says "4.14.1".

I'm happy to submit a PR if that'll help.

[nschonni]

That bump will be handled as part of the NPM publish apparently https://github.com/sass/node-sass/pull/3012

[nschonni]

Closing as v5 is out with Node 15 support. Thanks @xzyfer !

[xzyfer]

@nschonni you da real mvp