Node-sass: Node 9 support (module 59)

[nschonni]

Preemptivly opening this issue since Node 9 was released today. We'll use this issue to track adding the support and close other issues.

• [x] Update Travis #2130
• [x] Update Appveyor #2130, but blocked by https://github.com/appveyor/ci/issues/1895
• [x] Allow module 59 as a valid version #2130
• [x] Build OSX
• [x] Build Windows
• [x] Build Linux
• [x] Build Alpine
• [X] Build FreeBSD

Install version 4.6.0+ for Node 9 support

[stefanpenner]

is this fixed by: https://github.com/sass/node-sass/pull/2130 ?

[xzyfer]

Yes.

On 3 Nov. 2017 8:02 am, "Stefan Penner" [e-mail] wrote:

is this fixed by: #2130 https://github.com/sass/node-sass/pull/2130 ?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2129#issuecomment-341557061,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWGLHGRlWXMlh-VPUvze8OgWv_nGLks5syi3agaJpZM4QNXrU
.

[nschonni]

4.6.0 has been released with support for node 9 https://github.com/sass/node-sass/releases/tag/v4.6.0
There are bindings for Alpine and FreeBSD still missing, but they will just be attached to the release

[LaurentGoderre]

How do you get Alpine working? I'm really curious

[nschonni]

@LaurentGoderre info is over in #1996 in the linked repo. Should add some compose files though, but I never finished them up

[LaurentGoderre]

Aah so it's sort of a sneaky way! a good one though

[saper]

Strange, I encounter this error when trying to npm install --ignore-scripts on FreeBSD node 9.x:

/usr/local/bin/node[8979]: ../src/node_zlib.cc:430:static void node::<anonymous namespace>::ZCtx::Init(const FunctionCallbackInfo<v8::Value> &): Assertion `args.Length() == 7 && "init(windowBits, level, memLevel, strategy, writeResult, writeCallback," " dictionary)"' failed. *** Signal 6
Looks quite similar to https://github.com/nodejs/node/issues/13082

[nschonni]

Locking this as the only outstanding issue is FreeBSD binaries.

[saper]

Yep, uploaded for 4.7.2