Node-restify: Router.render() disappeared in 7, where did it go?

[mattbishop]

In Restify 6 one could pull up a named templated URI and replace the params with values to construct a URI. This was great for hypermedia APIs that create links to other resources.

This code was deleted in 7 (see https://github.com/restify/node-restify/commit/82832771826321480e5e524db258668f62b689c2) and I've looked everywhere for it's replacement.

Hints?

[retrohacker]

Hey @mattbishop,

I'm not sure what this is asking for, would you mind giving a code snippet of the original pattern?

[mattbishop]

Go to your User Guide: https://restify.github.io/docs/home/

Then scroll down to the Hypermedia section. This is missing in version 7.

[NShahri]

@retrohacker
Today I tried to upgrade from Restify 6 to 7 and I realised server.router.render is undefined. As @mattbishop mentioned in user guide it is used in Hypermedia section. Also I could not find anything in API section of user guide.

[DonutEspresso]

Thanks for the report, folks. FYI, in 7.x the homegrown router was replaced by find-my-way.

@hekike it looks like we kept support for named routes even in 7.x, I think it would be possible to restore this functionality. Is there any reason we couldn't do so?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[NShahri]

@DonutEspresso
Any luck about this issue.

[balexandre]

version 6 method: https://github.com/restify/node-restify/blob/v6.4.0/lib/router.js#L224

[balexandre]

@hekike @DonutEspresso brought it back on a PR... feel free to verify it :)

[tdd]

@hekike @DonutEspresso this sudden disappearance of render(), which is critical to hypermedia links and remains pimped in your docs through the Getting started guide, is super-annoying.

I'm building some of the material for my Node training class on Restify and not having it is a roadblock. I'll need to monkey-patch the router, which is less than ideal. Please look at the #1702 PR from @balexandre, I can only hope this gets merged and published ASAP!

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[balexandre]

don't let the stale-bot put this down...

[tdd]

So is Restify basically dead? The fact that this issue sees zero response from the team is scary… They basically break a beloved feature, not to mention break some important plugins that relied on the legacy route object structure, and they don't merge any PR in or ack the issue 😒

[tdd]

@hekike any reason this has gone completely ignored whilst two releases went out? Is there some fundamental disagreement as to this feature being brought back in? I had to do some nontrivial monkeypatching to get the current version to restore named routes and work with important community plugins again 😢

[xwlee]

I have just started to try out restify but bump to this issue. Look like the team doesn't care about this issue. Bye bye restify

[tdd]

@hekike way to get people to flee to other frameworks. Breaking changes that wreck the ecosystem and complete ignorance of issues and PRs. Might as well archive the repo and Mark it as unmaintained.

I audited this landscape when rewriting my node training course and went with restify, but the behavior since this fall's upgrade means I'll have to rewrite again to use a framework that actually gives a damn.

[balexandre]

@tdd I went back to expressJs :(

[petermorlion]

Paging @daviande who just released 7.7.0. Shouldn't the documentation be updated at least?

[tdd]

@petermorlion I fail to see how this issue was addressed in the current release.

[petermorlion]

@tdd It wasn't. But either the team should remove the part of the documentation (at a minimum) or else fix the issue. My point is, it's entirely fine for the Restify team to choose to close this issue as "wont-fix", but then the documentation should be updated.
But as they've just release 7.7.0, I guess there is still some work being done.

[tdd]

oh, yes, correct.

On Fri, Feb 8, 2019, at 10:46, Peter Morlion wrote:

@tdd https://github.com/tdd It wasn't. But either the team should remove the part of the documentation (at a minimum) or else fix the issue. My point is, it's entirely fine for the Restify team to choose to close this issue as "wont-fix", but then the documentation should be updated.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/restify/node-restify/issues/1684#issuecomment-461746896, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAOqP9RhUEZ8rMdGHhQs86pCrZbU4F7ks5vLUeBgaJpZM4U41Q1.

--
Christophe Porteneuve
[email protected]

[hekike]

Sorry, recently I didn't have much time to work on Restify. I removed the stale bot, it's not very helpful. @balexandre I understand your frustration, sorry about the very long response time.
Any chance you can reopen your PR? Or should I cherry pick your commit?

[yagomassiah]

Welp, really bad I left some hypermedia stuff left out for the end of the project and now need to rewrite to another framework. Hope you guys had different luck. Restify is great, but the feature I needed to implement was way too important to left that out.

[rajatkumar]

@yagomassiah router.render() should be available in the latest version. You might want to try that out.

[yagomassiah]

@rajatkumar Using restify 7.7 and still getting router.render is not a function. you had any success using it?

[rajatkumar]

I meant it is in v8.3.x. With Restify v8 we dropped support for Node6 so you shouldn't see anything else breaking if you move to the latest version.

[yagomassiah]

Any guides on how to migrate? npm install gives me restify 7.7 @rajatkumar

[rajatkumar]

npm install restify@latest --save should give you [email protected].

[yagomassiah]

@rajatkumar Thanks for all the help!