Node-restify: restify.CORS - error in documentation I guess

Created on 28 Mar 2014 · 9Comments · Source: restify/node-restify

At http://mcavage.me/node-restify/#Bundled-Plugins, CORS it stands:

server.use(restify.CORS())

I guess it should be server.pre(restify.CORS()); at least only with pre it work for me.
Also you should mention about restify.fullResponse() there.
Just spent one hour trying to handle CORS.

Open PR

Source

alekbarszczewski

Most helpful comment

Got me scratching for an entire afternoon for this one. I guess there might be something wrong with restify.CORS() and restify.fullResponse because preflight errors are intermittent. Now I'm using node-cors module as replacement to restify.CORS() and it worked without the errors now.

var cors = require('cors');

server.use(cors());
server.use(restify.fullResponse());

sydcanem on 21 Apr 2015

👍4

All 9 comments

+1 this solved my problem, thank you :)

The solutions I found while googling returned the old issue, #284, which doesn't include this solution (using .pre).

DTrejo on 4 Apr 2014

+1 this solved my problem, thank you :) (cp)

jbolila on 7 May 2014

Thanks :)

alejandrorigatuso on 10 May 2014

brugnara on 22 Jun 2014

+1 ...thanks!

timborden on 22 Jul 2014

thanks°° +1

jamesjara on 3 Jan 2015

var cors = require('cors');

server.use(cors());
server.use(restify.fullResponse());

sydcanem on 21 Apr 2015

👍4

Can you send a case to reproduce?

On Tuesday, April 21, 2015, James Santos [email protected] wrote:

Got me scratching for an entire afternoon for this one. I guess there
might be something wrong with restify.CORS() and restify.fullResponse
because preflight errors are intermittent. Now I'm using node-cors module
as replacement to restify.CORS() and it worked without the errors now.

var cors = require('cors');

server.use(cors());
server.use(restify.fullResponse());

—
Reply to this email directly or view it on GitHub
https://github.com/mcavage/node-restify/issues/573#issuecomment-94741598
.

Via mobile

yunong on 21 Apr 2015

Thanks everyone for patiently waiting for an update on CORS. The module now lives at https://github.com/TabDigital/restify-cors-middleware/

It also has been completely revamped to properly handle CORS requests :tada:! There is a new documentation website coming in the near future, and the current docs are being deprecated. Closing this issues as resolved for now :heart: if I'm missing a nuance and these issues are not resolved, comment and we can re-open to discuss!