Node-red-contrib-homekit-bridged: [Bug]: onChange output fires even no value has changed

Created on 13 Apr 2021  路  5Comments  路  Source: NRCHKB/node-red-contrib-homekit-bridged

Describe the bug
According to the readme the onChange output should only fire if the value has changed. Since I upgraded to version 1.3.3 onChange fires always no matter if the value changed or not.
{"payload":{"On":true},"hap":{"oldValue":true,"newValue":true},"name":"test2","topic":"","_msgid":"7a857ca5.38a234"}
In version 1.2.0 this worked out well and as expected so I assume this issue was introduced with the changes in version 1.3.0.

To Reproduce
Steps to reproduce the behavior:

  1. create a homekit switch node (or lightbulb, ...)
  2. send {"On":true} as payload to it a few times
  3. monitor the onChange output

Expected behavior
onChange should only fire if the value has changed.

bug

Most helpful comment

@Shaquu tested 1.3.4 and it works great.
Thank you for this great project and your amazing support!

All 5 comments

Hi @Delphius7 ,

May you please check in the bridge settings if "allow pass through" is disabled or enabled?

Thanks
Regards
THN

May you please check in the bridge settings if "allow pass through" is disabled or enabled?

@TheNON75
"Allow Message Passthrough" is enabled as this is needed for my flows.

Thanks and best regards!

I will try to look at it tonight. Either I will found an issue or I will apply a workaround we already have in mind.
Thanks for the report. homebridge/HAP-NodeJS#893

@Delphius7 please check with 1.3.4 (releasing now)

@Shaquu tested 1.3.4 and it works great.
Thank you for this great project and your amazing support!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

TristanMW picture TristanMW  路  8Comments

Kowy54 picture Kowy54  路  3Comments

Delphius7 picture Delphius7  路  3Comments

Shaquu picture Shaquu  路  9Comments

Shaquu picture Shaquu  路  10Comments