Node-rdkafka: v2.7.3 release

Created on 18 Oct 2019 · 14Comments · Source: Blizzard/node-rdkafka

@webmakersteve since there was confusion regarding version v2.7.2 that was published as v2.7.1-2 (#663) and since we didn't hear from you for a few months, I decided to merge #665 that solves Node 12 incompatibility. I also fixed e2e tests, improved and fixed travis ci tests and updated librdkafka to 1.2.1 (#684).
I was hoping that travis will execute npm publish since that stage seems well defined in .travis.yaml. I figured that the latest tag will be used as npm version when publishing and that this tag should point to the latest commit as well to bypass -x version suffix (which represents the number of commits between the latest tag and the latest commit).
Finally, I decided to try to trigger npm publish by tagging the latest commit with v2.7.3 but as I expected that didn't work. It looks like you'll again have to manually publish this version but be aware of .vscode (#670)

Hope this makes sense.

Update:
I fixed travis deployment stage but provided API key for NPM apparently doesn't work.
I'll now delete v2.7.3 tag. We're stuck until @webmakersteve comes back.

Source

iradul

👍3

Most helpful comment

Node12 has moved into LTS,We need a version to support it.

yuu2lee4 on 21 Oct 2019

👍15 🚀10

All 14 comments

Any idea when a new proper version can be released? it is very annoying to have an issue on versioning and vscode on our production (image weight additional 1GB for no reason). We have a warning and no cache on the build of this module and it is the only one who take a lot of time to build (no prebuild include !)

vincent-ogury on 18 Oct 2019

@iradul Is @webmakersteve the only one with the npm creds to release the package? If they don't have time to do it, it'd have to be a fork or at least a new package?

brettkiefer on 18 Oct 2019

👍1

Is @webmakersteve the only one with the npm creds to release the package?

yes, there are some credentials in .travis.yml for NPM publishing but they don't work

iradul on 18 Oct 2019

Arf... I need the Node 12 compatibility. I hope someone will find a solution!

Themandunord on 19 Oct 2019

👍1

Node12 has moved into LTS,We need a version to support it.

yuu2lee4 on 21 Oct 2019

👍15 🚀10

I tried your forked version,It likely not support node12? @iradul

yuu2lee4 on 28 Oct 2019

I would like to have the latest in npm as well. Cant install against node12 today easily.

josephxsxn on 29 Oct 2019

Hi everybody,
just wanted to let you know, that I published a version with the node12 related fixes of this repo and fixes for some other problems I encountered:

https://www.npmjs.com/package/@circle/node-rdkafka

donjuandem on 30 Oct 2019

👍3

@donjuandem @peterdemartini I tried your version,its ok installing with node 12,but cant connect to broker.

yuu2lee4 on 7 Nov 2019

v2.7.3 is now published :fireworks:

iradul on 12 Nov 2019

🎉4

Same issue as the 2.7.2 on the release of the 2.7.3!
Version in the package is set to "version": "v2.7.2-8".
That confuses the "yarn" package manager and lead to reinstalling every time we run a "yarn install" even if it is already there.

Can you release a 2.7.4 with package set to 2.7.4 in the package.json please?

Thanks.

vincent-ogury on 13 Nov 2019

Same issue as the 2.7.2 on the release of the 2.7.3!
Version in the package is set to "version": "v2.7.2-8".
That confuses the "yarn" package manager and lead to reinstalling every time we run a "yarn install" even if it is already there.

This happened because the package was published manually by webmakersteve. In the publishing process, there is a script that actually updates package.json version number according to the latest tag and latest commit distance from this tag.