Node-rdkafka: sasl.username / password not supported

[eshao]

Please consider this a feature request, I suppose.

Although cited in https://raw.githubusercontent.com/edenhill/librdkafka/2213fb29f98a7a73f22da21ef85e0783f6fd67c4/CONFIGURATION.md, they throw an error as per below.

/node-rdkafka/lib/client.js:59
  this._client = new SubClientType(globalConf, topicConf);
                 ^

Error: No such configuration property: "sasl.username"
    at Error (native)
    at Producer.Client (/Users/eshao/wsp/tty1/workers/node_modules/node-rdkafka/lib/client.js:59:18)
    at new Producer (/Users/eshao/wsp/tty1/workers/node_modules/node-rdkafka/lib/producer.js:71:10)
    at Object.<anonymous> (/Users/eshao/wsp/tty1/workers/k2.js:9:16)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.runMain (module.js:575:10)

[webmakersteve]

Looks like that feature was added in the version following the one we distribute. I'd be happy to update the librdkafka version provided with the source though!

[eshao]

Cool! Any idea when the bump might be made?

[eshao]

Also, it might be nice to document the version of rdkafka in the README.md

[webmakersteve]

After checking the source we compile against, it looks like sasl.username should be supported (according to the version's Configuration.md). I changed the README to link to the configuration.

According to the releases page, it looks like 0.9.1-1 has only been released to the confluent and debian repos. I'd prefer that we wait to bump the version until Magnus makes an official version bump on the releases page to ensure its stability. However, we should still have SASL support.

It is likely that librdkafka is being compiled without SASL in your situation. Can you ensure that you have libsasl2-dev installed?

[webmakersteve]

Ahh. We turned libsasl off by default via a configure argument in librdkafka. I have put it back into the build process only when you specify the environment variable WITH_SASL=1. Make sure you have libsasl2 installed if you build it that way and let me know if that fixes your issue. You can find the code at #26

[webmakersteve]

Another change! It is now on by default, so no need to run anything extra :) Merging the PR too.

[eshao]

:+1:

[eshao]

Oh, it might be nice if you bumped the version for npm. Thanks!

[cjolif]

Any news, is that possible to release a new NPM package?

[webmakersteve]

Bumped to 0.4.0 on npm

[cjolif]

thanks!