Node-jsonwebtoken: SyntaxError instead of JsonWebTokenError

[sm2017]

Description

Sometime verify throws SyntaxError instread of JsonWebTokenError

Reproduction

var jwt = require("jsonwebtoken")
const malformed_token='eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c';

jwt.verify(
        malformed_token,
        'Secret',
        {
          algorithms: [ 'HS256' ],
        }
      );

Environment

Version of this library used: 8.5.1

[sm2017]

@ziluvatar reply please

[ziluvatar]

The payload of that token is not well built, if you try to base64 decode you'll find that it does not contain a JSON payload, you will see something like

{"sub":"1234567890","name":"HX]MLML

[sm2017]

@ziluvatar yes , I know, I just told that throwing SyntaxError is not good behavior, instead we must throw JsonWebTokenError

Do you have other idea?

[ziluvatar]

I tagged this and another similar one as bug. I mean, you are right we should raise one of our errors.

[sm2017]

@ziluvatar The issue a about stale , Do you have plan to fix it? and the issue tagged as a bug

[sm2017]

@ziluvatar 😓

[asvsfs]

I've changed a single line returning default error to JsonWebTokenError type , see if this solves the problem #735