Node-fetch: Bug: Differences in package installation locations of devDependencies based on package manager

Created on 24 May 2020 · 4Comments · Source: node-fetch/node-fetch

Reproduction

Steps to reproduce the behaviour:

Run yarn
Run yarn test

Since yarn installs binaries like c8 to a different directory than npm, it can't find the absolutely declared directories in the test script.

Expected behaviour

The binary directories shouldn't be absolutely declared but detecting them or using esm would affect coverage. We should either switch back to nyc or use Node.js v13.2.0 for testing which has esm module support enabled by default.

Your Environment

| software | version
| ---------------- | -------
| node-fetch | a6a933fa5a
| node | 12.14.1
| npm | 6.13.4
| yarn | 1.19.1
| Operating System | Windows 10 v1903

bug

Source

Richienb

Most helpful comment

Actually, is that something we should care about? We do not use yarn nor we ever declared compatibility with it.

Sure, it would be awesome if people could use it when developing new features, but if that means we would need to make some weird workarounds, I don't think it's worth it.

xxczaki on 24 May 2020

👍2

All 4 comments

Using Node.js v13.2.0 or even later sounds good to me.

xxczaki on 24 May 2020

👍1

Actually, is that something we should care about? We do not use yarn nor we ever declared compatibility with it.

Sure, it would be awesome if people could use it when developing new features, but if that means we would need to make some weird workarounds, I don't think it's worth it.

xxczaki on 24 May 2020

👍2

@Richienb there are also PnP mode in Yarn@2 that doesn't create node_modules at all and pnpm package manager if you are seeking complete intimacy with all possible managers. But I agree with @xxczaki - we don't use Yarn at this project neither declare any compatibility with a non-default manager and this issue affects only developers participating in this module - so, we just can set team rules and relax.