Node_exporter: ZFS for FreeBSD

[sachaz]

It's a surprise to see the ZFS working on Linux and not FreeBSD, could it be considered ?

[discordianfish]

For some reason we removed freebsd support from the zfs PR. Might be because it required root. But in general we're open to adding this as long as it's possible under the constraints we have: https://github.com/prometheus/node_exporter/blob/master/CONTRIBUTING.md#collector-implementation-guidelines

@dominikh I read in #369 that you wanted to look into adding freebsd back?

[dominikh]

I'm afraid I don't have the time to do that anymore.

[discordianfish]

@dominikh Totally understand that. Any chance you remember some details why we didn't include it in the first place? Is there some blockers that would need to be addressed first?

[dominikh]

@discordianfish See https://github.com/prometheus/node_exporter/pull/213#discussion_r57543554 and https://github.com/prometheus/node_exporter/pull/213#issuecomment-246737535

[discordianfish]

@dominikh Ah, thanks!

So yeah, we would like to include zfs support on freebsd as long as it doesn't require executing some binary or root privileges.

[sachaz]

thanks !

[xaque208]

I was looking for zfs bindings in golang last night, but none seem to support FreeBSD. Does anyone know of one that I've missed? FreeBSD seems to use libzfs_core.h, while the linux folks are using libzfs.h, and the object signatures seem to be different in the https://github.com/bicomsystems/go-libzfs project, that I wasn't able to compile the package.

[derekmarcotte]

For what it's worth, there is this: https://github.com/mmatuska/zfs-stats/blob/master/zfs-stats

Most, if not all, of the ZFS cache stats are exposed via sysctl on FreeBSD.

The structures used in the referenced script are not up to date, and give some weird values around the L2ARC, for example. I was definitely planning to add this, once we started building out more comprehensive dashboards.

I could start poking now though, if this is interesting?

[discordianfish]

@derekmarcotte Yeah would be great to have this!

[ltning]

Yes please. Any progress here?

[derekmarcotte]

Hi - sorry for the radio silence. The node_exporter work isn't as high a priority for my organization at the moment, so it's been my free time work, and hasn't been on my radar at the moment. I'll see how picking it up again goes this month.

[ltning]

That would be awesome. We are pretty heavy users, let me know if there is anything we can do to help or encourage :)

[ghost]

Is there any ETA on this? Would be very useful

[discordianfish]

Closed by #1394