Node.bcrypt.js: app is crashing while using bcrypt's async methods

[manishmawat]

app is crashing while using bcrypt package in the app, to test it separately I put the code in a separate file as below.
1) tried to put the constant (10) value in the hash function instead of getting in getSalt function.
2) tried to catch the error in different ways but not getting any error.
3) if I comment the bcrypt function then everything else (if I have anything) working fine in the function.

    const bcrypt = require('bcrypt');
    async function run(){
    const saltValue =await bcrypt.genSalt(10);
    bcrypt.hash('12345',saltValue)
    .then(result => console.log(result))
    .catch(error => console.log(error));
    }
    run();

Version: node : 9.0.0 npm: '5.5.1' "bcrypt": "^3.0.2"
OS: Windows 7.

[manishmawat]

The app is crashing for asynchronous functions only.
I tried to use synchronous functions and it is working fine.

const saltValue = bcrypt.genSaltSync(10);
const hashed = bcrypt.hashSync('12345',saltValue);

[recrsn]

Please give the error message

[manishmawat]

executing it with node is not giving any output, but nodemon is showing it as app crash.

And changing it with the synch methods successfully giving the output.

[recrsn]

Try to run without nodemon and post the error. You may be hitting an unhandled promise rejection error

[manishmawat]

With node it is not giving any output:

I wish I had that unhandled promise error but it is not giving anything.
Just to debug it more I tried below code with more edge cases.

const bcrypt = require('bcrypt');
async function run(){
    try{
    console.log('beforeTest');
    const saltValue = await bcrypt.genSalt(10);
    const hashed = await bcrypt.hash('12345',saltValue);
    console.log(hashed);
    console.log('test');
}
catch(error)
{
    console.log(error);
}
console.log('AfterTest');
}
run();

And the output is:

[AyKarsi]

can confirm the above behaviour on windows 10. both on node 8.9.2 and 10.13.0 using 3.0.2
On linux (suse and ubuntu) it works fine.
Reverting to 3.0.0 works for me at the moment.

[manishmawat]

@AyKarsi, I have tried on Windows 7 with node 9.0.0 only and it is working only for synchronous methods, not for asynchronous.

[recrsn]

Strange, I do not find that behavior on Windows 10 and Node 8 or Node 11

[markterence]

@manishmawat
I tried Bcrypt 3.0.2 in Windows 7 with Node 8.9.1 and using async methods made my app(express server) crash.
Using [email protected] works fine, async and sync methods works.
npm i --save --save-exact [email protected]
It made me stick to use [email protected] since [email protected] crashed on my node 8.9.1
Hope that helps.

(Edited: Sorry for the mistake it was bcrypt-3.0.2 and not bcrypt-3.0.1)

[recrsn]

Could you please create a crashdump using DebugDiag? https://blogs.msdn.microsoft.com/chaun/2013/11/12/steps-to-catch-a-simple-crash-dump-of-a-crashing-process/

[markterence]

Hi, here is the zipped crashdump using DebugDiag.

https://www.dropbox.com/s/om6aszrmju1bfbo/FullCab_Date__11_28_2018__Time_09_27_33AM_1.cab?dl=0

[raugaral]

Solution here:
https://github.com/kelektiv/node.bcrypt.js/issues/664#issuecomment-430860141

[Tech-engine]

For "bcrypt": "^3.0.2", Upgrading to Node v10 solved the problem for me.

[recrsn]

Looks like the resurfacing of a similar error for NodeJS in OSX. The ABI compatibility of NodeJS is horrible. I'm still investigating a fix

[theprometeus]

Having the same problem, using Windows 10 with Node v8.9.4

[Dandan1314]

same problem, using archlinux with node v8.9.2

[e-gautier]

This thing keep silently crashing my app.

[e-gautier]

I mean "silently terminating", because that's the real term, callback simply isn't called.

[recrsn]

Should be fixed with new version and using a NodeJS version other than v8.9.x

[mijatovicmile]

I had the same issue with Node.js version 8.9.4 and I successfully fixed the issue with installing recommended version of bcrypt based on my Node.js version

I fixed the issue with [email protected]

Important note: Before you install bcrypt, first check version of Node.js on your machine, and based on that, install appropriate version of bcrypt

[recrsn]

@mijatovicmile All versions >= 1.0.3 are compatible with NodeJS 8 except v8.9.x that minor version is problematic.

[gdrbyKo1]

Encountered this today while running inside Docker. In my case this was caused by using node:lts-slim during build, and then copying the artifacts over to a node:lts-alpine-based image. As these two variants use different libc implementations, native libs built with either may not work with the other.
It's a mistake I've made in my Dockerfile, of course, but I wish I had received at least some hint as to what could be causing this, rather than the Node runtime just terminating like this 😂 (not bcrypt's fault)