Node-addon-api: Next release 2.0.0

[KevinEady]

Hi @NickNaso ,

I am currently working on a PR to address https://github.com/nodejs/node-addon-api/issues/556#issuecomment-544634867 like we discussed yesterday. I am waiting on #546 copy ctor before pushing it though. I think this is a good addition for 2.0.0 as well. I will add it to the list once I create a PR.

[legendecas]

https://github.com/nodejs/node-addon-api/pull/545 introduced a breaking change on the usage of the definition of NAPI_EXPERIMENTAL, it would be nice to land such a change on the next semver major version.

[NickNaso]

545 introduced a breaking change on the usage of the definition of NAPI_EXPERIMENTAL, it would be nice to land such a change on the next semver major version.

@legendecas I added #545 to the list.

[KevinEady]

If this is a major version release, can we get rid of https://github.com/nodejs/node-addon-api/blob/master/napi-inl.deprecated.h ...?

[gabrielschulhof]

@KevinEady good point!

[NickNaso]

@KevinEady @gabrielschulhof could we remove the file without consequences? Is it right?

[gabrielschulhof]

@NickNaso there were also some conditionally defined sections that needed removing.

https://github.com/nodejs/node-addon-api/pull/572

[NickNaso]

@NickNaso there were also some conditionally defined sections that needed removing.

572

Added to the list with #573 .

[mhdawson]

Not sure we want to do all: remove deprecated stuff but keep infra - Merge PR #572. While technically we can because its a SemVer major, we decided to do a major only because of changes we believe will have not effect on existing users. My preference would to avoid trully breaking changes.

[gabrielschulhof]

I'm OK with deferring the removal of the deprecated stuff. I've struck out the PR from the checklist.

[legendecas]

Just a thought: maybe we could utilize labels and GitHub milestone/project to track the releasing process. :P

[arielweinberger]

Can't wait for @legendecas' pull request bringing AsyncProgressWorker to node-addon-api! Thank you everybody!

[extmchristensen]

Really excited about this new release (in particular with "tsfn: Implement copy constructor" which is a key feature that really makes a diff). I just hope the orginal scope is not increased too much so it gets delayed.

[mhdawson]

@NickNaso I think we are pretty much ready to make the new release.

[NickNaso]

@mhdawson I will wait until tomorrow just in case someone want add other things in the release.

[NickNaso]

Hi everyone I'm starting to create and publish the new release ...

[NickNaso]

Hi @gabrielschulhof @mhdawson,
I prepared all to publish the new release but we have problems on Node.js version 11 https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/1067/. I think that I can proceed to publish on npm. Is it ok for you?

[gabrielschulhof]

@NickNaso it looks like the CI is having trouble running Node.js v11.

[mhdawson]

@NickNaso at this point 11 is long out of service. The failures also look to me like issues with the configuration of the job (versus anything in the tests) that I probably only fixed up for 12 and later.

From my perspective those failures are 11 are not a concern.

[mhdawson]

The one on 13 was also likely a machine issue but started a new one for 13 to be sure.
https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/1076/

[NickNaso]

Hi @mhdawson,
now we have failures for all Node.js version on AIX, but I think that is an infrastructure problem:

Could someone help o solve this problem?

[NickNaso]

The CI is green now and I will proceed to publish the new release on npm.
Sorry it's not true I missed test on Node.js version 8 that are failing on AIX.

[mhdawson]

Those might still be machine issues, but the problem is that the other machines are off line so we'll need to get that figured out @sam-github

[NickNaso]

The CI now is green:

• Node.js v8 ✓
• Node.jsv10 ✓
• Node.js v12 ✓
• Node.js v13 ✓
• Node.j v14 (master) ✓

I'm going to complete the work to publish the release.

[NickNaso]

I'm closing the issue because the new release has been published.