Nnn: Update SESSIONS_VERSION to 1 before next release

Created on 20 Oct 2019  路  13Comments  路  Source: jarun/nnn

See title.

Most helpful comment

I see xargs being used in src/nnn.c, what did you mean by this?

xargs has multiple sources - GNU xargs, BSD xargs, Busybox xargs other independent POSIX xargs. Now even the most minimal xargs would work with nnn.

if you keep a list of maintainers somewhere make sure to add me in

Sure! You'll get the notis I send on new releases.

All 13 comments

Note 2: dependency on findutils for xargs removed. Notify maintainers.

@annagrram can you please locally test and confirm when we bump the session version, users who have already created sessions with master have their sessions working?

Without testing I can say it won't work by design

OK, I see why in the code. But why don't we attempt backward compatibility?

We can try, but it requires a bit more design, work, checks and headaches :P

I understand. Let's do one thing. Can we have an extra byte in the header start that holds the number of items stored? That way we will have some info later on how many items we need to load. Now if we retain the order of store and load we will always remain backward and forward compatible even if we extend the number of items we store later.

Rather than the number of items stored I should call it the number of items intended for storing... because sometimes the strings can be NULL and we will have no data for it other than string length info (that it's 0-length).

@annagrram I think we are OK with what we have, even if it's hard. The bottleneck is settings, if we change flags, it wouldn't work.

Yeah.
There are ways to make structs extendable and therefore backward compatible, but they are either non-standard or ugly.

:(

Added this in the ToDo list.

Note 2: dependency on findutils for xargs removed. Notify maintainers.

I see xargs being used in src/nnn.c, what did you mean by this?

By the way, I maintain the package for Arch Linux now, if you keep a list of maintainers somewhere make sure to add me in 馃槈

I see xargs being used in src/nnn.c, what did you mean by this?

xargs has multiple sources - GNU xargs, BSD xargs, Busybox xargs other independent POSIX xargs. Now even the most minimal xargs would work with nnn.

if you keep a list of maintainers somewhere make sure to add me in

Sure! You'll get the notis I send on new releases.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kuntau picture kuntau  路  3Comments

tim77 picture tim77  路  9Comments

deadpyxel picture deadpyxel  路  5Comments

akimdi picture akimdi  路  5Comments

leovilok picture leovilok  路  3Comments