Nlog: GetCurrentClassLogger in base class wrong Class logger

[giammin]

public abstract class BaseClass
{
    private Logger _logger;
    protected Logger Logger
    {
        get { return _logger ?? (_logger = LogManager.GetCurrentClassLogger()); }
    }
}

public class Derived : BaseClass
{
    public Derived()
    {
        Logger.Info("test");
        // Logger "BaseClass"
        // Expected "Derived"  
    }
}

Workaround:
_logger = LogManager.GetLogger(GetType().Name)

[304NotModified]

I would expect "baseclass" because it's defined in baseclass.

This is expected behavior.

[304NotModified]

What would you expect with class Derived2: BaseClass...?

[giammin]

What would you expect with class Derived2: BaseClass...?

logger: Derived2

BaseClass is an abstract class. I expect that it use the instantiated class

[304NotModified]

Yes but the method is not abstract

[giammin]

the method says: GetCurrentClassLogger

I expect the current instantiated class, maybe I'm wrong...

[giammin]

So what is the best practice if i want to have a base abstract class with a logger?

[304NotModified]

The best practice it to create a private field for each class. So each class have:

private Logger _logger = LogManager.GetCurrentClassLogger(); //or static if desired. 

There is no benefit creating this in an abstract class IMO

[giammin]

the benefit is to not have to implement a logger in all derived classes

[304NotModified]

It saves 1 line of code for each class, yes.

LogManager.GetLogger(GetType().Name) looks also fine to me.

[ghost]

Closed as this seems answered, please reopen if needed