Nlog: Implement MailTarget for .NET Core

[304NotModified]

Feature

The mail target isn't supported in net core as Microsoft didn't port the mail classes. See link platform support.
https://github.com/NLog/NLog/wiki/platform-support

SMTPClient is not supported, see https://github.com/dotnet/corefx/issues/1006
but we could use MailKit https://www.nuget.org/packages/MailKit/

[304NotModified]

how to implemented this:

1. fork
2. create new branch from coreCLR branch
3. implement using mailkit for UWP10 (we still have to rename it)
4. add/enable unit tests
5. send PR to coreCLR branch

[UgurAldanmaz]

I see two coreCLR branches with git bash; upstream/coreCLR and NLog/coreCLR. I am not sure which branch I need.

Also master branch is used to rebase in contributing.md.

git rebase upstream/master

Do I need to rebase with coreCLR instead of master?

git rebase upstream/coreCLR

[304NotModified]

I think NLog/coreCLR , but please post the output of following command:

git remote -v (in the nlog folder)

[UgurAldanmaz]

Thanks Julian.

I will able to take look at weekend.

[UgurAldanmaz]

Hey @304NotModified.

Here is the output of git remote -v command:

$ git remote -v
NLog    https://github.com/NLog/NLog.git (fetch)
NLog    https://github.com/NLog/NLog.git (push)
origin  https://github.com/UgurAldanmaz/NLog.git (fetch)
origin  https://github.com/UgurAldanmaz/NLog.git (push)
upstream        https://github.com/NLog/NLog.git (fetch)
upstream        https://github.com/NLog/NLog.git (push)

[304NotModified]

So NLog and upstream are the same. If there aren't the same locally, use git fetch -a (fetch all).

You could drop one of the remotes, I would remove "upstream"

You could do that in TortioseGit (contextmenu -> settings)

or

git remote rm upstream

[UgurAldanmaz]

I added upstream according to our contributing instructions :)

Ok. I will be available next week.

[mb2140]

Looking forward to this! Is there a branch available that I can test out?

[UgurAldanmaz]

Hi @mb2140. Thanks for your interest. Unfortunately I could not find free time to work on this yet.

But I will complete as soon as possible.

[304NotModified]

@mb2140 if you like to test it soon, maybe it's easier to create your own extension. We could guide you how to set this up.

[spottedmahn]

MailKit Officially Replaces .NET’s SmtpClient

[spottedmahn]

hello - any updates on this issue/missing feature? We would really like to use the mail target!!

[304NotModified]

Nope. It should not to be difficult to implement though. I could help you with that.

[304NotModified]

I have created an additional package for this - the NLog.MailKit package

With your config it should work :)

Also add this to your config:

<extensions>
    <add assembly="NLog.MailKit"/>
</extensions>

Currently not implemented:

• Encoding
• PickupDirectory
• NTLM auth

[M-R-Bishop]

@304NotModified Installed and working great so far. Thanks for working on this!

[304NotModified]

Thanks! Encoding also added :)

[304NotModified]

If everything works well, I will create a final release soon.