Njs: invoke accessors in Object.defineProperties()

[drsm]

>> var o = Object.defineProperties({}, { get x() { return { value: 1 }; } })
undefined
>> Object.getOwnPropertyDescriptor(o, 'x').value
TypeError: cannot get property "value" of undefined
    at main (native)

[xeioex]

@drsm please try the following patch
https://gist.github.com/xeioex/36a7e33198679f46d2d0f733a9f2b92f

  - Ran 32254 tests
- - Passed 10338 tests (32.1%)
- - Failed 21916 tests (67.9%)
+ - Passed 10376 tests (32.2%)
+ - Failed 21878 tests (67.8%)

[drsm]

@xeioex

The patch looks fine, thanks!

[drsm]

Found a problem:

This place looks wrong.
An extensible flag should not be checked on update of property descriptor (spec)

var o = {};
Object.defineProperty(o, 'x', { configurable: true, get() { return 1; } });
Object.preventExtensions(o);
Object.defineProperty(o, 'x', { configurable: true, value: 2 });
o.x // 2

var o = {}
Object.defineProperty(o, 'x', { configurable: true, value: 1 });
Object.preventExtensions(o);
Object.defineProperty(o, 'x', { configurable: true, get() { return 2; } });
o.x // 2

=== built-ins/Object/defineProperty/8.12.9-9-b-i_1 failed in strict mode ===
=== built-ins/Object/defineProperty/8.12.9-9-b-i_2 failed in strict mode ===
=== built-ins/Object/defineProperty/8.12.9-9-c-i_1 failed in strict mode ===
=== built-ins/Object/defineProperty/8.12.9-9-c-i_2 failed in strict mode ===

Should I create another issue?

[xeioex]

@drsm

An extensible flag should not be checked on update of property descriptor (spec)

Good catch. Thanks.

Should I create another issue?

No. I will fix it as a part of this issue.