Njs: String.prototype.split() fails to split a unicode string correctly

[drsm]

Hi!

>> '\u0431\u0435,\u043b\u0438,\u0431\u0435\u0440,\u0434\u0430'.split(',')
[
 'бе',
 'ли',
 'бер',
 'да'
]
>> '\u0431\u0435,\u043b\u0438,\u0431\u0435\u0440,\u0434\u0430'.split('')
[
 '�',
 '�',
 '�',
 '�',
 ',',
 '�',
 '�',
 '�',
 '�',
 ',',
 '�',
 '�',
 '�',
 '�',
 '�',
 '�',
 ',',
 '�',
 '�',
 '�',
 '�'
]
>> 

[drsm]

while our unicode strings are not UTF-16 strings, i think we should not break surrogate pairs there, as required by the spec.
more on this:
https://stackoverflow.com/questions/4547609/how-do-you-get-a-string-to-a-character-array-in-javascript/34717402#34717402

[xeioex]

@drsm Thank you for the report.

Please, try the patch below:
https://gist.github.com/xeioex/35d9cc06fb9559ca32ce1e085c7f2d92

>> 'αβγ'.split('')
[
 'α',
 'β',
 'γ'
]

>> '囲碁織'.split('')
[
 '囲',
 '碁',
 '織'
]

>> '𝟘𝟙𝟚𝟛'.split('')
[
 '𝟘',
 '𝟙',
 '𝟚',
 '𝟛'
]

>> 'яαяαяα'.split('α')
[
 'я',
 'я',
 'я',
 ''
]

[drsm]

@xeioex
the patch works fine for me, thanks!

>> 'фыва asdf 👍'.split('')
[
 'ф',
 'ы',
 'в',
 'а',
 ' ',
 'a',
 's',
 'd',
 'f',
 ' ',
 '👍'
]