Nixpkgs: nixos test-driver fails on master

Created on 21 Nov 2020  Â·  3Comments  Â·  Source: NixOS/nixpkgs

Describe the bug
Black formatting issue.
https://hydra.nixos.org/build/130880394

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...
  3. ...

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
bug channel blocker

Most helpful comment

I think this is annoying, but we should not make a too big of a deal out of it. Unless this of course becomes a regular thing.

Would not be much of an issue if black was a good fit in the first place — because of variable expansion, there is no good way to reformat a NixOS VM test defined as a Nix string with some variables. This is bad even without upstream bugs.

All 3 comments

Hmm, if a package bump of black can have this kind of impact, I'm wondering if we should reconsider having a mandatory style check in our VM tests.

We want to have a common style, so we use a tool. If a tool like Black has this type of "bug", there is no way around it, and it becomes your new style. If the "bug" is then resolved, you need to update your code.

I think this is annoying, but we should not make a too big of a deal out of it. Unless this of course becomes a regular thing.

I think this is annoying, but we should not make a too big of a deal out of it. Unless this of course becomes a regular thing.

Would not be much of an issue if black was a good fit in the first place — because of variable expansion, there is no good way to reformat a NixOS VM test defined as a Nix string with some variables. This is bad even without upstream bugs.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

edolstra picture edolstra  Â·  3Comments

domenkozar picture domenkozar  Â·  3Comments

lverns picture lverns  Â·  3Comments

ghost picture ghost  Â·  3Comments

grahamc picture grahamc  Â·  3Comments