Nixpkgs: thunderbird: It's branded as thunderbird daily, although it's a release version

[mkg20001]

Describe the bug
Seems like it really does use release source code, so it should be branded as that

To Reproduce
Steps to reproduce the behavior:

1. Open thunderbird

Expected behavior
Should be branded as thunderbird _release_ not _daily_

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

Metadata

• system: "x86_64-linux"
• host os: Linux 4.19.89, NixOS, 20.03pre-git (Markhor)
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.3.1
• channels(root): "nixos-20.03pre205780.d942688fc13"
• nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: thunderbird
# a list of nixos modules affected by the problem
module:

[andersk]

This seems to be required by the Mozilla trademark guidelines.

https://github.com/NixOS/nixpkgs/blob/ad7c7cfe7a6873e17078478a845168ebefb4aa17/pkgs/applications/networking/mailreaders/thunderbird/default.nix#L63-L68

If you want the official branding, you can either recompile thunderbird with enableOfficialBranding, or install thunderbird-bin.

It’s possible we could ask for an exemption here like we did for Firefox (#31843).

[mkg20001]

OK, that would be cool if you did

Anders Kaseorg [e-mail] schrieb am Do., 19. Dez. 2019,
01:36:

This seems to be required by the Mozilla trademark guidelines.

https://github.com/NixOS/nixpkgs/blob/ad7c7cfe7a6873e17078478a845168ebefb4aa17/pkgs/applications/networking/mailreaders/thunderbird/default.nix#L63-L68

If you want the official branding, you can either recompile thunderbird
with enableOfficialBranding, or install thunderbird-bin.

It’s possible we could ask for an exemption here like we did for Firefox (

31843 https://github.com/NixOS/nixpkgs/issues/31843).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/issues/75904?email_source=notifications&email_token=AB3AO2NA7VL7MOGZY5M7O53QZK62HA5CNFSM4J4TXMB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHH7CWY#issuecomment-567275867,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3AO2NI5TTJ3K7YI3NLHHTQZK62HANCNFSM4J4TXMBQ
.

[mkg20001]

Is the thunderbird trademark still owned by mozilla? I've heard thunderbird & the rest of mozilla are now different entities.

[mkg20001]

Also even with

    thunderbird = pkgs.thunderbird.override {
      enableOfficialBranding = true;
    };

it seems to appear as daily and not release. Possibly the flags need to be adjusted?

[prusnak]

Following the same logic as in https://github.com/NixOS/nixpkgs/issues/31843 I think we should be able to use the official branding for Thunderbird too. It seems that Debian also renamed Icedove do Thunderbird quite some time ago and I'm pretty sure the wouldn't do so if that was a problem.

I would vote for setting enableOfficialBranding to true by default.

[LouisDK1]

I've made this pull req: https://github.com/NixOS/nixpkgs/pull/94880