Nixpkgs: networking.wireless nixos module name leads to confusion

Created on 22 Nov 2019  路  5Comments  路  Source: NixOS/nixpkgs

Describe the bug
networking.wireless makes it sound like you need it enabled for wifi, this is not the case and most wifi users probably want networking.networkmanager instead.

I propose we rename this option set to networking.wpa_supplicant (while providing an alias for backwards) compat, and change all the documentation to reflect the new naming.

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: networking.wireless networking.networkmanager

cc @jtojnar @flokli @symphorien @worldofpeace @peterhoeg @dtzWill

bug stale nixos

Most helpful comment

We spoke about that during the NixOS networkd meetup aswell (notes still pending to be uploaded to discourse), but yes, this is really unintuitive, and should be moved to services.(wpa_)supplicant .

All 5 comments

I think I can speak for the maybe 15 people I've encountered that had no idea what software networking.wireless was. If it were a custom nixos interface working with everything wireless in existence, maybe it could be so abstract. But you can clearly identify here it's just wpa_supplicant, and I've also thought it should just be named as such. It's just as identifiable as network-manager and the last thing you want is someone to be confused/misconstrued on which network setup they have. Especially if you're switching to NixOS.

I propose we rename this option set to networking.wpa_supplicant

The problem is we already have networking.supplicant, to complicate things further. See https://github.com/NixOS/nixpkgs/issues/22401

In my opinion we should really rewrite the whole module to be backend independent, though it's a lot of work.

We spoke about that during the NixOS networkd meetup aswell (notes still pending to be uploaded to discourse), but yes, this is really unintuitive, and should be moved to services.(wpa_)supplicant .

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

I think a good first start would be to rename this to services.wpa_supplicant (and not yet be backend independent). Any takers?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

teto picture teto  路  3Comments

yawnt picture yawnt  路  3Comments

sid-kap picture sid-kap  路  3Comments

copumpkin picture copumpkin  路  3Comments

matthiasbeyer picture matthiasbeyer  路  3Comments