Nixpkgs: rust: 1.17

Created on 23 May 2017  路  10Comments  路  Source: NixOS/nixpkgs

Issue description

Please update to 1.17!

Also, our current version (1.15) doesn't support LLVM 4 :(.

I tried tackling this but the build changed (requires rustbuild now?) and I'm not sure how that should be handled in NixOS.

Steps to reproduce

Technical details

  • System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)
  • Nix version: (run nix-env --version)
  • Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)
  • Sandboxing enabled: (run grep build-use-sandbox /etc/nix/nix.conf)
package (update)

Most helpful comment

I took it a bit further, with updates to beta and nightly as well, and also a bit of cleaning up. If I don't hit any bugs I'll send a PR (or anyone else who's in a hurry is welcome to test it a bit and send the PR themselves)

https://github.com/anderspapitto/nixpkgs/commits/rust-updates

All 10 comments

cc rustc maintainers for input and so this is at least in their inbox: @madjar @cstrahan @wizeman @globin @havvy @wkennington @retrry

If folks have ideas how to handle this but not time, I'd be willing to do the grunt work with some guidance O:).

I had almost working 1.16 with rustbuild, but I didn't have time to finish.

I copied rustbuild configuration from, I think, Fedora RPM spec file for rustc. The only thing with 1.17 is that, I think, vendored libs are only included in tarball. So you would need to change rustbuild to not use fetchgit when building release version.

cc @LnL7 as he is active in rust pull requests :)

Does anyone have a work in progress branch?

My colleague @jcranmer was awesome and put together enough to get a working rustStable! :tada:

With his permission, I've pushed his work to the 'update/rust-1.17' branch.

It'll need some more work (particularly handling the rustBeta/rustNightly bits) but hopefully serves as a good starting point!

@dtzWill let me know if you want help testing/fixing the changes on darwin, altho I don't want to stall the update (a second time) if it's too tricky to get working.

I don't plan on working on this in the near future, FWIW, so this is open to anyone who's to the task! :).

I took it a bit further, with updates to beta and nightly as well, and also a bit of cleaning up. If I don't hit any bugs I'll send a PR (or anyone else who's in a hurry is welcome to test it a bit and send the PR themselves)

https://github.com/anderspapitto/nixpkgs/commits/rust-updates

Do send a PR (even if with a "don't merge" warning) so that we can do review. I, for one, can't wait!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vaibhavsagar picture vaibhavsagar  路  3Comments

lverns picture lverns  路  3Comments

copumpkin picture copumpkin  路  3Comments

grahamc picture grahamc  路  3Comments

ob7 picture ob7  路  3Comments