Add a openPortsInFirewall option, with a default of true. It's pretty pointless to run a matrix server without connecting to other ones.
This could be said about most of our services. It'd be nice if we could abstract over common service patterns like the enable option and port settings. I.e., some sort of function that produces the { config, ... }: { options = ...; config = ... } structure but takes care of automatically managing common repetitive crap like this.
Ideal to me feels like:
firewall.openServicePortsByDefault, defaulting to falseservice.foo.openPorts, with a default value of firewall.openServicePortsByDefaultfirewall.openServicePortsByDefault = true;, services open ports by default, but you can opt individual services out by setting service.foo.openPorts = false;Either way see #19504
Closing because this is, as pointed out by @copumpkin, discussed in #19504.
Most helpful comment
This could be said about most of our services. It'd be nice if we could abstract over common service patterns like the enable option and port settings. I.e., some sort of function that produces the
{ config, ... }: { options = ...; config = ... }structure but takes care of automatically managing common repetitive crap like this.Ideal to me feels like:
firewall.openServicePortsByDefault, defaulting tofalseservice.foo.openPorts, with a default value offirewall.openServicePortsByDefaultfirewall.openServicePortsByDefault = true;, services open ports by default, but you can opt individual services out by settingservice.foo.openPorts = false;Either way see #19504