Nix: flake input url doesn't support branches with slashes

Created on 24 Sep 2020  路  4Comments  路  Source: NixOS/nix

Describe the bug

It seems that branches with slashes in them (e.g. feat/flake) aren't supported in input urls.
Neither of these work:
"github:Myhlamaeus/pre-commit-hooks.nix/feat/flake"
"github:Myhlamaeus/pre-commit-hooks.nix?ref=feat/flake"

Steps To Reproduce

Reference a git branch with a / in a flake.nix, for example:

inputs.pre-commit-hooks.url = "github:Myhlamaeus/pre-commit-hooks.nix/feat/flake";

Expected behavior
Flake should be downloaded.

nix-env --version output
nix-env (Nix) 3.0pre20200829_f156513

bug
Source
picture felschr
👍4

Most helpful comment

I don't think the first one should be supported since it's pretty ambiguous.

It's better in this case to use the attrset notation:

inputs.pre-commit-hooks = {
  type = "github";
  owner = "Myhlamaeus";
  repo = "pre-commit-hooks.nix";
  ref = "feat/flake";
};
picture edolstra on 8 Oct 2020
👍2

All 4 comments

Related: https://github.com/nixos/nix/issues/3612

felschr picture felschr on 24 Sep 2020

@felschr would you mind testing #4115 :)

Ma27 picture Ma27 on 6 Oct 2020

I don't think the first one should be supported since it's pretty ambiguous.

It's better in this case to use the attrset notation:

inputs.pre-commit-hooks = {
  type = "github";
  owner = "Myhlamaeus";
  repo = "pre-commit-hooks.nix";
  ref = "feat/flake";
};
edolstra picture edolstra on 8 Oct 2020
👍2

It could be supported for the ?ref= case though, no?

AluisioASG picture AluisioASG on 20 Nov 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

vizanto picture vizanto  路  3Comments
drewm1980 picture drewm1980  路  3Comments
dasJ picture dasJ  路  3Comments
bryanhuntesl picture bryanhuntesl  路  3Comments
copumpkin picture copumpkin  路  3Comments