Nix: "Dumping very large path" message isn't helpful

Created on 11 Jan 2017  路  8Comments  路  Source: NixOS/nix

It would be helpful to know which path is being dumped and ideally what led to the dumpage. Given where the warning is emitted right now in the code, it's not obvious to me how to add that detail to the message, but it's pretty unfriendly right now. I guess we could add a constructor parameter to an FdSink that tells it some human-meaningful representation of the thing being written to it?

cc @edolstra @shlevy

Error Messages UX

Most helpful comment

(well, actually, using constant space for dumping is obviously the way to go :stuck_out_tongue: )

All 8 comments

Yeah, a message in FdSink constructor seems the way to go.

(well, actually, using constant space for dumping is obviously the way to go :stuck_out_tongue: )

@edolstra how come 01d33eab235b0f7ef770c0168eba9c795772be4d never landed in master?

@domenkozar That patch doesn't apply cleanly without cf4a7ae26de6d8869856d3beddfe8eb2440578a3.

Having both would be really great :)

@edolstra would you mind explaining what withholds these two commits back?

These are two of the most annoying bugs I encounter when using Nix and even being experienced they are annoying to overcome.

I think it's better to make it work&correct and we can correct the performance one day if needed.

This is still an issue today. I just got that error message and don't know what path is causing the issue.

Was this page helpful?
0 / 5 - 0 ratings