Nivo: BarCanvas is broken

Created on 12 Nov 2020  路  2Comments  路  Source: plouc/nivo

Description

BarCanvas implementation is broken.

Reproduction

https://nivo.rocks/storybook/?path=/story/barcanvas--custom-tooltip

Screenshot 2020-11-12 at 15 24 07

I'm currently trying to figure out what is exactly the issue and what could be a fix.

bar bug

Most helpful comment

Hey, thanks for taking a look! I am betting it is because it is missing the new valueScale prop I added. You will need to pull it from props and add it to the options object that is passed to the generate bars functions here: https://github.com/plouc/nivo/blob/e98d8e071ae474526621761ba03d608d9a2971ec/packages/bar/src/BarCanvas.js#L106

It is where I would start anyways. :)

All 2 comments

Hey, thanks for taking a look! I am betting it is because it is missing the new valueScale prop I added. You will need to pull it from props and add it to the options object that is passed to the generate bars functions here: https://github.com/plouc/nivo/blob/e98d8e071ae474526621761ba03d608d9a2971ec/packages/bar/src/BarCanvas.js#L106

It is where I would start anyways. :)

@wyze wouah thanks for the fast answer. Definitely sounds like something I've seen in my debug session so far. 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

stahlmanDesign picture stahlmanDesign  路  3Comments

PattieC4ke picture PattieC4ke  路  3Comments

vagnervst picture vagnervst  路  4Comments

barnapisti1994 picture barnapisti1994  路  3Comments

p45mark picture p45mark  路  3Comments