Nim: [RFC] skip CI runs (travis/AppVeyor) when AST doesn't change

Created on 10 Jul 2018  路  6Comments  路  Source: nim-lang/Nim

travis/AppVeyor can take a while to run, could this optimization be done:

* upon a git push, check if previous state before that push was green; if it was, and if commit doesn't change AST (eg only comments or spacing that doesn't change AST), then skip running travis/AppVeyor

EDIT:

  • upon a git push, f commit doesn't change AST (eg only comments or spacing that doesn't change AST), then skip running travis/AppVeyor ; the state shown is same as before that git push (whether failing or passing)
  • as an escape solution, closing / reopening PR would still trigger travis/AppVeyor

This would make improving docs an easier process

EDIT as mentioned below, see Related PR #6999

RFC

Most helpful comment

The last thing we need is "clever" testing. Even whitespace changes can break the documentation generation, for example.

All 6 comments

Sure, we can add lots of rules like this. We need to make sure these rules can detect the desired circumstances reliably though.

(edited above)

The last thing we need is "clever" testing. Even whitespace changes can break the documentation generation, for example.

Even whitespace changes can break the documentation generation, for example.

for these, we could run only documentation generation, not the whole test suite

Related PR #6999

Since @Araq didn't like neither #6999 nor this revival, I'm closing this as a rejected proposal.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

zielmicha picture zielmicha  路  37Comments

ErikSchierboom picture ErikSchierboom  路  29Comments

anthraxx picture anthraxx  路  26Comments

yglukhov picture yglukhov  路  46Comments

kvinwang picture kvinwang  路  29Comments