Nilearn: [Quality] Duplication: nilearn/regions/signal_extraction.py

Created on 5 Dec 2019  路  7Comments  路  Source: nilearn/nilearn

The following lines in nilearn/regions/signal_extraction.py are duplicated and should be refactored:

Lines 100-116, 183-200

https://github.com/nilearn/nilearn/blob/7fd55bad75a087ac591edf4c00c85a5806a1c461/nilearn/regions/signal_extraction.py#L100-L116

https://github.com/nilearn/nilearn/blob/7fd55bad75a087ac591edf4c00c85a5806a1c461/nilearn/regions/signal_extraction.py#L183-L200

Good first issue code quality
Source
picture kchawla-pi

Most helpful comment

Hey @NicolasGensollen, if that's fine for you, I could take the issue

picture ChristianGerloff on 5 May 2021
🚀1 👍1

All 7 comments

By refactored, in this case do you mean you'd like a function which does these things called twice instead of near-verbatim code repeat?

jbteves picture jbteves on 13 Feb 2020
👍1

@kchawla-pi I'm interested in working on this. Can I do that?

KranthiGV picture KranthiGV on 10 Jul 2020
👍1

@jeromedockes @emdupre

kchawla-pi picture kchawla-pi on 12 Jul 2020

@jbteves duplicated code should be in a private function called whenever needed.
Both you @KranthiGV are welcome indeed !

bthirion picture bthirion on 12 Jul 2020
🚀1 👍1

Hey @NicolasGensollen, if that's fine for you, I could take the issue

ChristianGerloff picture ChristianGerloff on 5 May 2021
🚀1 👍1

Thx ! let us know if you need help.

bthirion picture bthirion on 5 May 2021

alright, thx

ChristianGerloff picture ChristianGerloff on 5 May 2021
Was this page helpful?
0 / 5 - 0 ratings

Related issues

kchawla-pi picture kchawla-pi  路  7Comments
jdkent picture jdkent  路  7Comments
htwangtw picture htwangtw  路  4Comments
nilover picture nilover  路  7Comments
thomasbazeille picture thomasbazeille  路  9Comments