Ngx-scanner: Publish npm package under scope (refactoring needed)

Created on 31 Jan 2018  路  10Comments  路  Source: zxing-js/ngx-scanner

I think we can do this for v1.0.0, a major release indicating that some things will change completely.

We also gotta decide what name use for the scanner component, maybe NgxScannerComponent and NgxScannerModule? (maybe it's too generic)

  • [x] Publish package.
  • [x] Rename classes.
  • [ ] Release G.A. version.
enhancement help wanted

Most helpful comment

Well... Good point! :grin: Let's go without the prefix then

All 10 comments

First dev version published named as @zxing/ngx-scanner. Component not renamed yet, it will be named as ZXingScannerModule.

Component selector will be zxing-scanner. Should we put the ngx- in the selector?

I would say so. Makes it obvious that it is an angular component

Do you need to say that this is a Angular component when you use inside Angular the package is already published under the ngx- preffix?

Well... Good point! :grin: Let's go without the prefix then

I finished the refactoring (I think..).

Can ya do some review to the code? I'm really anxious about finishing this.

Will do! 馃憤馃徎

Looks good, lets go 馃榿

I'm currently working on a Plunkr example which can then be exported and added to the docs-folder so a demo can be accessed via github.io
The docs-folder is the only folder I found the old ngx-zxing name so I think were ready for an initial release now

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ngeor picture ngeor  路  4Comments

rastajpa picture rastajpa  路  7Comments

odahcam picture odahcam  路  5Comments

ilellouch picture ilellouch  路  4Comments

odahcam picture odahcam  路  6Comments