Ngx-quill: Angular 7 compatibility

[jed-meyer]

During the Angular 7 update process, ngx-quill 3.6.0 complains about peer dependencies since it requires Angular 5.x or 6.x.

Is Angular 7 compatibility on its way already?

[KillerCodeMonkey]

I did Not tried it, yet. Feel free to Test it in your own. And send me a pr
:)

jed-meyer [e-mail] schrieb am Sa., 20. Okt. 2018, 13:47:

During the Angular 7 update process, ngx-quill 3.6.0 complains about peer
dependencies since it requires Angular 5.x or 6.x.

Is Angular 7 compatibility on its way already?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/KillerCodeMonkey/ngx-quill/issues/262, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ACKOYN3B06O-KImDojc2Tfu9KJTFFf5Gks5umw02gaJpZM4Xx4cc
.

[markgoho]

263

[KillerCodeMonkey]

Nice one!

Mark Goho [e-mail] schrieb am Sa., 20. Okt. 2018, 16:39:

263 https://github.com/KillerCodeMonkey/ngx-quill/pull/263

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/KillerCodeMonkey/ngx-quill/issues/262#issuecomment-431587456,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACKOYJ6LIu4nJr9paah1x7h4wE-FIiRVks5umzWegaJpZM4Xx4cc
.

[jed-meyer]

That's great news! Any chance the major version will be aligned with Angular's?

[KillerCodeMonkey]

Nope because i am also depending on quilljs. So it is possible to have
breaking changes between angular major releases.

jed-meyer [e-mail] schrieb am So., 21. Okt. 2018, 03:10:

That's great news! Any chance the major version will be aligned with
Angular's?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/KillerCodeMonkey/ngx-quill/issues/262#issuecomment-431630210,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACKOYA1Mge7p7PqU7Rkr02_9f3EYx0hbks5um8l9gaJpZM4Xx4cc
.

[markgoho]

@KillerCodeMonkey anything I can do on the PR to get it pushed through?

[KillerCodeMonkey]

What so You mean with pushed through? I will Look into it next week. ;)

Mark Goho [e-mail] schrieb am So., 21. Okt. 2018, 21:49:

@KillerCodeMonkey https://github.com/KillerCodeMonkey anything I can do
on the PR to get it pushed through?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/KillerCodeMonkey/ngx-quill/issues/262#issuecomment-431698329,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACKOYPXC7_96hMMgdMNKYD5sVQBu0kpmks5unM_GgaJpZM4Xx4cc
.

[markgoho]

Sorry, I mean, is there anything you need changed on the PR in order to Merge it into the project. Please let me know when you've had time to review.

[KillerCodeMonkey]

@markgoho would be nice if you could checkout the other pr for angular 7.
https://github.com/KillerCodeMonkey/ngx-quill/pull/264/files

Could you validate if this version specification is working as well? So we do not need to exclude older Angular versions.

If so, please change this in your pr :)

[markgoho]

I'm not sure how I would test that. Wouldn't folks who aren't on v7 of Angular just stick with v3.x of ngx-quill?

[KillerCodeMonkey]

checkout v4