Ngx-charts: Fix NPM warnings with Angular 7

[kathomas921]

I'm submitting a ... (check one with "x")

• [X] bug report - search github for a similar issue or PR before submitting
• [ ] feature request
• [ ] support request - use StackOverflow (add the ngx-charts tag) or the gitter chat for support questions

Current behavior
After upgrading to Angular 7.0.0 and running NPM install, I see
npm WARN @swimlane/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself. npm WARN @swimlane/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself. npm WARN @swimlane/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself. npm WARN @swimlane/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself. npm WARN @swimlane/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself.

Expected behavior
There should be no warnings.

Reproduction of the problem

• ngx-charts version: 9.0.0
  

• Angular version: 7.0.0
  

• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  

• Language: [TypeScript 3.1.1]

[bop10]

In fact, you can't use ng update @angular/material to update Angular Material or CDK to 7 right now cause of this:

Package "@swimlane/ngx-charts" has an incompatible peer dependency to "@angular/cdk" (requires "6.x", would install "7.0.1").
Incompatible peer dependencies found. See above.

@marjan-georgiev

[estechco]

It does seem to work with ng7, but I had to ensure I'd upgraded @angular bits (as above) BEFORE I installed @swimlane/ngx-charts. Temporary uninstall/upgrade/reinstall should work?

[blogcraft]

Until there is no official support of Ng 7 you need to do the ng update with the --force flag to skip those pesky warnings.

[mbeckenbach]

If you want to update using ng update:
ng update @angular/cli @angular/core @angular/cdk @angular/material --force

This ignores the incompatible error.

[marjan-georgiev]

Released 10.0.0 which should address this. Please let me know if you still see issues.

[bop10]

thanks! @marjan-georgiev

[kuadrosx]

Hi, I am getting message
Package "@swimlane/ngx-charts" has a missing peer dependency of "d3" @ "^4.10.2"
Updating to 10.0.0

[marjan-georgiev]

@kuadrosx you need to install d3 in your app.

npm i --save [email protected]

[the-ult]

@kuadrosx you need to install d3 in your app.

npm i --save [email protected]

Is this something to add to the install docs?

Or shouldn't it be a devDependency or something, since it is a hard dependency

[abishekram]

npm WARN @swimlane/[email protected] requires a peer of @angular/[email protected] || 8.x but none is installed. You must install peer dependencies yourself.

@marjan-georgiev Is angular cdk mandatory for ngx-charts.? or I can just simply ignore the warnings

[limthengwai]

getting same warning as @abishekram .

npm WARN @swimlane/[email protected] requires a peer of @angular/[email protected] || 8.x but none is installed. You must install peer dependencies yourself

Please update us if anyone encounter it before. Thanks

[Rajsekar89]

@limthengwai , Am also facing this same warning.

Could any one let us know, whether we ignore this warning.

[estechco]

Re-install or update, I suspect, will now work? Think the original issue was eventually fixed

[limthengwai]

Re-install or update, I suspect, will now work? Think the original issue was eventually fixed

nope, @Rajeshsekaran4488 facing the same issue too.

[chadupton]

@marjan-georgiev Is angular cdk mandatory for ngx-charts.? or I can just simply ignore the warnings

It seem like it is required -- I had to install CDK to get it working...

npm install @angular/cdk --save

[Hypercubed]

Yes... @angular/cdk is required.

[celesteking]

$ ng update  @angular/material@7
                  Package "@swimlane/ngx-charts" has an incompatible peer dependency to "@angular/common" (requires "7.x" (extended), would install "10.1.6").
                  Package "@swimlane/ngx-charts" has an incompatible peer dependency to "@angular/animations" (requires "7.x" (extended), would install "10.1.6").
                  Package "@angular/http" has an incompatible peer dependency to "@angular/core" (requires "7.2.15" (extended), would install "10.1.6").
                  Package "@swimlane/ngx-datatable" has an incompatible peer dependency to "@angular/compiler" (requires "<8.0.0" (extended), would install "10.1.6").
                  Package "@angular/http" has an incompatible peer dependency to "@angular/platform-browser" (requires "7.2.15" (extended), would install "10.1.6").
                  Package "@swimlane/ngx-charts" has an incompatible peer dependency to "zone.js" (requires "^0.8.26", would install "0.10.3").
                  Package "@swimlane/ngx-charts" has an incompatible peer dependency to "@angular/forms" (requires "7.x" (extended), would install "10.1.6").
                  Package "@swimlane/ngx-charts" has an incompatible peer dependency to "@angular/platform-browser-dynamic" (requires "7.x" (extended), would install "10.1.6").
Incompatible peer dependencies found. See above.

$ npm list @swimlane/ngx-charts  @swimlane/ngx-datatable
+-- @swimlane/[email protected] 
`-- @swimlane/[email protected] 

fix your shit, man.