Ngx-charts: Update deps to Angular 6 and rxjs 6

Created on 30 Apr 2018  路  9Comments  路  Source: swimlane/ngx-charts

What is the motivation / use case for changing the behavior?

  • To keep up with the latest and greatest
  • Reduce code size and improve build speed

Most helpful comment

Released in ngx-charts 8.0.0

All 9 comments

current version 7.3.0 run-time fail with Angular 6, EVEN with the help of "rxjs-compat": "6",


index.js:57266 Uncaught TypeError: Object(...) is not a function
at index.js:57266
at Object../src/index.ts (index.js:57292)
at __webpack_require__ (index.js:35)
at ./node_modules/angular2-moment/add.pipe.js.__decorate (index.js:78)
at index.js:81
at webpackUniversalModuleDefinition (index.js:8)
at Object../node_modules/@swimlane/ngx-ui/release/index.js (index.js:15)

For me, with the version 7.3.0, I can serve my application locally, but when I try to build it for production, I got this errors:

ERROR in ./node_modules/@swimlane/ngx-charts/release/common/base-chart.component.js
Module not found: Error: Can't resolve 'rxjs/observable/fromEvent' in '/xxx/node_modules/@swimlane/ngx-charts/release/common'
ERROR in ./node_modules/@swimlane/ngx-charts/release/common/base-chart.component.js
Module not found: Error: Can't resolve 'rxjs/operators/debounceTime' in '/xxx/node_modules/@swimlane/ngx-charts/release/common'

@byunru Yes, I can see this error also in my PR. #827
Possible to share code? I think it is because ngx-ui doesn't support it yet? And that would make it a dev dependancy only, as the PR runs the tests correctly.

Given https://github.com/swimlane/ngx-charts/pull/812 I think this issue has been resolved and can be closed?

Though I think it would likely be appropriate to also first bump the major version of the library as I don't think earlier Angular versions will work.

Not, cannot be closed. #812 broke the tests, #827 fixes this, but the demo page is still not working, due to devDepedancies that are not compatible with NG6.

Yep. I get the following build errors:

ERROR in ./node_modules/@swimlane/ngx-charts/release/common/base-chart.component.js
Module not found: Error: Can't resolve 'rxjs/observable/fromEvent' in 'D:\code\**\node_modules\@swimlane\ngx-charts\release\common'
ERROR in ./node_modules/@swimlane/ngx-charts/release/common/base-chart.component.js
Module not found: Error: Can't resolve 'rxjs/operators/debounceTime' in 'D:\code\**\node_modules\@swimlane\ngx-charts\release\common'

the same problem. I get the following error:
Package "ngx-charts" has an incompatible peer dependency to "rxjs" (requires "5.0.1", would install "6.1.0").

Released in ngx-charts 8.0.0

Tested serving and build in prod mode, it works like charm now ! Big thanks @marjan-georgiev ;-)

Was this page helpful?
0 / 5 - 0 ratings