Ngx-charts: [ngx-advanced-pie-chart] legend goes outside parent container

Created on 25 Jan 2017  路  9Comments  路  Source: swimlane/ngx-charts

I'm submitting a ... (check one with "x")

[x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior

When the parent container of the ngx-advanced-pie is bigger than the pie itself, the legend is displayed under the pie-chart.

ngx-advanced-pie-chart_bug

I think this has to do with

.advanced-pie-legend {
    float: left;
    position: absolute;
    top: 50%;
    transform: translate(0, -50%);
}

Expected behavior

I would expect the legend to always be displayed next to the chart.
This should fix it.

ngx-charts-advanced-pie-chart{
 position: relative;
}

Reproduction of the problem

See: https://plnkr.co/edit/?p=preview (full-screen)

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Windows 10
  • Chrome Version 55.0.2883.87 m (64-bit)
  • ngx-charts version: 4,0,0

D:\dev\bereslim\bsm-ui>ng --version

                             _                           _  _
  __ _  _ __    __ _  _   _ | |  __ _  _ __         ___ | |(_)
 / _` || '_ \  / _` || | | || | / _` || '__|_____  / __|| || |
| (_| || | | || (_| || |_| || || (_| || |  |_____|| (__ | || |
 \__,_||_| |_| \__, | \__,_||_| \__,_||_|          \___||_||_|
               |___/
angular-cli: 1.0.0-beta.25.5
node: 6.9.1
os: win32 x64
@angular/common: 2.4.4
@angular/compiler: 2.4.4
@angular/core: 2.4.4
@angular/flex-layout: 2.0.0-beta.3
@angular/forms: 2.4.4
@angular/http: 2.4.4
@angular/material: 2.0.0-beta.1
@angular/platform-browser: 2.4.4
@angular/platform-browser-dynamic: 2.4.4
@angular/router: 3.4.4
@angular/compiler-cli: 2.4.4
Bug Easy High

All 9 comments

Regression from latest release likely.

Should be fixed in 4.0.1. Please let me know.

Thanks for the quick response, fix and release.
But it doesn't seem to be solved.

Can you share the plunker link please? The one you posted in your original message is not correct.

The plunker link from you're demo/site seem to be broken:
https://swimlane.gitbooks.io/ngx-charts/content/charts/pie-chart.html
That's why the plunker isn't working anymore

Here is a link with a reference to the latest master (4.0.1)
https://plnkr.co/edit/y3l5472m1fv1pEMIqGDo?p=preview

Problem still seems to exists

Got it, I see it now, thanks! Pushed a fix.

Works perfectly with 4.0.3

Thanks

Was this page helpful?
0 / 5 - 0 ratings

Related issues

NashIlli picture NashIlli  路  3Comments

DZDomi picture DZDomi  路  4Comments

workfel picture workfel  路  3Comments

Jacquers picture Jacquers  路  3Comments

lokeshdaiya picture lokeshdaiya  路  3Comments