Ngx-bootstrap: Error in selected days visualization when showWeekNumbers is set to false in DateRangePicker

Created on 21 Jul 2020  路  5Comments  路  Source: valor-software/ngx-bootstrap

Bug description:

When using the date range picker component, the view for selected days is different if the week number is shown or not ( showWeekNumbers: false ).

Example of the selection with week numbers:
imagen
This can be seen at : https://valor-software.com/ngx-bootstrap/#/datepicker#date-initial-state

Example of selection without week numbers:
imagen
This can be seen at: https://valor-software.com/ngx-bootstrap/#/datepicker#format

Versions of ngx-bootstrap, Angular, and Bootstrap:

Examples taken from the documentation (https://valor-software.com/ngx-bootstrap/#/datepicker)

Build system: Angular CLI, System.js, webpack, starter seed:

Examples taken from the documentation (https://valor-software.com/ngx-bootstrap/#/datepicker)

Expected behavior

Same view, without separation between days

comp(datepicker)

Most helpful comment

Well, I found that this issue exist even in 3+ versions of ngx-bootstrap, which are sooooo ooold.
I've also found an interesting case , check my screenshot below

It looks like, that issue with spaces appears only for 4th day in week row, which is even more strange
Selection_045

This issue is really old, and nobody saw that, looks like, nobody hides weekNumbers for daterangepicker :rofl:

Thanks again for finding that, @JoseLlorensRipolles !
Fix will be ready soon, and, available in next release, I suppose, in the beginning of the August

All 5 comments

Woah, that's look really strange!
Thanks for finding this out!

I should say, I've never seen such things before, so, maybe that can be related to migration to Angular 9, somehow
Anyway, gonna check that this week, and, try to fix

Thanks again, @JoseLlorensRipolles for that!

Hey! Thank you for your quick response!

I actually found this on a project using:

ngx-bootstrap: 5.3.2
Angular: 8.2
Bootstrap: 4.4.0

I just thought that it would be clearer if reported directly from documentation, but it may help you if you think the problem is migration related.

Thank you very much!!

Ah, so looks like it's not related to migration, maybe, it was broken from the beginning :laughing:

Will check :)

Well, I found that this issue exist even in 3+ versions of ngx-bootstrap, which are sooooo ooold.
I've also found an interesting case , check my screenshot below

It looks like, that issue with spaces appears only for 4th day in week row, which is even more strange
Selection_045

This issue is really old, and nobody saw that, looks like, nobody hides weekNumbers for daterangepicker :rofl:

Thanks again for finding that, @JoseLlorensRipolles !
Fix will be ready soon, and, available in next release, I suppose, in the beginning of the August

Awesome work! Thank you very much Dmitriy!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ghiscoding picture ghiscoding  路  3Comments

srjkrl20011991 picture srjkrl20011991  路  3Comments

hugonne picture hugonne  路  3Comments

MihaiHoriaPopescu picture MihaiHoriaPopescu  路  3Comments

tpiros picture tpiros  路  3Comments