Ngx-bootstrap: [Proposal] Remove moment.js from dependencies to reduce bundle size

[Iverson]

I found only one place in source code where moment.js is used - https://github.com/valor-software/ngx-bootstrap/blob/27a022922370947d54c3cfd357399eb588e8d01f/src/datepicker/date-formatter.ts#L5
But it inflates every bundle with import {...} from 'ng2-bootstrap' by 452kb! (89kb with gzip)

webpack-bundle-analyzer report:

I propose to get rid of moment.js, instead we can use native Date() objects or date-fns, as it is modular and much smaller.

[GiuseppePiscopo]

If it's only a matter of formatting date as text, this library could rely on Angular DatePipe as in date => datePipe.transform(date, dateFormat); with its own set of format specifiers.

[valorkin]

Initial intent to use it was localizations it provides

[Iverson]

I think 452kb is too high cost for it.

[valorkin]

You can cut it out http://stackoverflow.com/questions/25384360/how-to-prevent-moment-js-from-loading-locales-with-webpack

[Iverson]

Are you realy think this is a good solution? Not all uses webpack, not all will even know why bundle size increased and will found this workaround. In my opinion would be better if ngx-bootstrap was optimized by default, for any build tools.

[valorkin]

Any bundle could be good for all tools, and yes will be optional later

[BrainCrumbz]

@valorkin thanks for sharing the intent. Is localization going to be implemented soon? If not, removing dependency from momentjs could be an instant improvement.

If localization is going to be implemented in near future, have you thought about possible alternatives? Like taking advantage of Angular DatePipe own localization for string conversion? Are there other requirements for localization? Maybe something about translating days of the week an month names: there could be some other lighter implementation available already.

[agnislav]

+1 to have it removed.

[valorkin]

removed in v1.9.0 ;)
plus added new datepicker (new style and pop up version)
check this out: http://valor-software.com/ngx-bootstrap/#/datepicker#examples