Ngx-bootstrap: In Bootstrap 4, use Font Awesome in Rating component

[Hongbo-Miao]

Just a suggestion, in Bootstrap 4, maybe switch to Font Awesome for Rating component by default?

Or somehow provide a way to let developer choose? Thanks

[Slavrix]

Not just rating component, datepicker and several others all use glyphicons which aren't included with bootstrap 4.

[jprinaldi]

Removable tabs use Glyphicons as well. I'm resorting to Font Awesome on my local copy.

Has any decision been made regarding this matter?

[valorkin]

Font Awesome will be used only for BS3 templates
after new datepicker I will provide a better way of templates segregation

[mlybrand]

for Rating, you could provide a hook for icon prefix. defaults to glyphicon, but you could set it to fa or opticon or whatever...

[mlybrand]

Let me know if you would accept a PR and what you would like to see as a minimum (documentation, test coverage, etc), assuming you would be willing to accept a PR.

[valorkin]

fixed :D