Nginx-rtmp-module: Getting error on make command Ubuntu 18.04

[meverikxp]

Hi, Trying to install nginx-rtmp-module and I getting same issue on serveral ubuntu versions
sudo make make -f objs/Makefile make[1]: Entering directory '/home/alek/build/nginx-1.12.0' cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/nginx.o \ src/core/nginx.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_log.o \ src/core/ngx_log.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_palloc.o \ src/core/ngx_palloc.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_array.o \ src/core/ngx_array.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_list.o \ src/core/ngx_list.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_hash.o \ src/core/ngx_hash.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_buf.o \ src/core/ngx_buf.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_queue.o \ src/core/ngx_queue.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_output_chain.o \ src/core/ngx_output_chain.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_string.o \ src/core/ngx_string.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_parse.o \ src/core/ngx_parse.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_parse_time.o \ src/core/ngx_parse_time.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_inet.o \ src/core/ngx_inet.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_file.o \ src/core/ngx_file.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_crc32.o \ src/core/ngx_crc32.c cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../nginx-rtmp-module -I objs \ -o objs/src/core/ngx_murmurhash.o \ src/core/ngx_murmurhash.c src/core/ngx_murmurhash.c: In function ‘ngx_murmur_hash2’: src/core/ngx_murmurhash.c:37:11: error: this statement may fall through [-Werror=implicit-fallthrough=] h ^= data[2] << 16; ~~^~~~~~~~~~~~~~~~ src/core/ngx_murmurhash.c:38:5: note: here case 2: ^~~~ src/core/ngx_murmurhash.c:39:11: error: this statement may fall through [-Werror=implicit-fallthrough=] h ^= data[1] << 8; ~~^~~~~~~~~~~~~~~ src/core/ngx_murmurhash.c:40:5: note: here case 1: ^~~~ cc1: all warnings being treated as errors objs/Makefile:543: recipe for target 'objs/src/core/ngx_murmurhash.o' failed make[1]: *** [objs/src/core/ngx_murmurhash.o] Error 1 make[1]: Leaving directory '/home/alek/build/nginx-1.12.0' Makefile:8: recipe for target 'build' failed make: *** [build] Error 2

Can you help me with it? Thank you!

[DeadSix27]

@meverikxp apply this patch, should make it build again

diff -Nur a/ngx_rtmp_eval.c b/ngx_rtmp_eval.c
--- a/ngx_rtmp_eval.c   2018-06-02 19:23:28.993466673 +0200
+++ b/ngx_rtmp_eval.c   2018-06-02 19:23:26.532371311 +0200
@@ -166,6 +166,7 @@
                         state = ESCAPE;
                         continue;
                 }
+                /* fall through */

             case ESCAPE:
                 ngx_rtmp_eval_append(&b, &c, 1, log);

[ustoopia]

In Ubuntu 18.04 you only need to install nginx as you would normally do (apt install nginx-full) and afterwards just do apt install libnginx-mod-rtmp. The only thing you need to do then is edit the config files and edit the RTMP part and the locations and such.

[gdomod]

use nginx-1.13.8.tar.gz

[Alirezaies]

so we can't build Nginx from source on Ubuntu 18.04? any tutorial about how to build Nginx with Modules?
thanks

[aminhusni]

@meverikxp apply this patch, should make it build again

diff -Nur a/ngx_rtmp_eval.c b/ngx_rtmp_eval.c
--- a/ngx_rtmp_eval.c 2018-06-02 19:23:28.993466673 +0200
+++ b/ngx_rtmp_eval.c 2018-06-02 19:23:26.532371311 +0200
@@ -166,6 +166,7 @@
                         state = ESCAPE;
                         continue;
                 }
+              /* fall through */

             case ESCAPE:
                 ngx_rtmp_eval_append(&b, &c, 1, log);

THIS WORKS THANKS

[flouthoc]

Works fine with nginx 1.14.2

[nashirox]

Works fine with nginx 1.14.2

@flouthoc me too 👍

[KevinZhanggg]

In Ubuntu 18.04 you only need to install nginx as you would normally do (apt install nginx-full) and afterwards just do apt install libnginx-mod-rtmp. The only thing you need to do then is edit the config files and edit the RTMP part and the locations and such.

where can I find the configuration file? any hint?

[ustoopia]

/etc/nginx/nginx.conf

From: KevinZhanggg [e-mail]
Sent: vrijdag 5 maart 2021 19:49
To: arut/nginx-rtmp-module [e-mail]
Cc: ustoopia [e-mail]; Comment [e-mail]
Subject: Re: [arut/nginx-rtmp-module] Getting error on make command Ubuntu 18.04 (#1255)

In Ubuntu 18.04 you only need to install nginx as you would normally do (apt install nginx-full) and afterwards just do apt install libnginx-mod-rtmp. The only thing you need to do then is edit the config files and edit the RTMP part and the locations and such.

where can I find the configuration file? any hint?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/arut/nginx-rtmp-module/issues/1255#issuecomment-791611712 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGZM6CLYGBY52IADV7WER6DTCERSHANCNFSM4E5HXCYQ . https://github.com/notifications/beacon/AGZM6CPFAQXFGXOGOHOFIODTCERSHA5CNFSM4E5HXCY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOF4XQSQA.gif

[KevinZhanggg]

/etc/nginx/nginx.conf From: KevinZhanggg [e-mail] Sent: vrijdag 5 maart 2021 19:49 To: arut/nginx-rtmp-module [e-mail] Cc: ustoopia [e-mail]; Comment [e-mail] Subject: Re: [arut/nginx-rtmp-module] Getting error on make command Ubuntu 18.04 (#1255) In Ubuntu 18.04 you only need to install nginx as you would normally do (apt install nginx-full) and afterwards just do apt install libnginx-mod-rtmp. The only thing you need to do then is edit the config files and edit the RTMP part and the locations and such. where can I find the configuration file? any hint? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1255 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGZM6CLYGBY52IADV7WER6DTCERSHANCNFSM4E5HXCYQ . https://github.com/notifications/beacon/AGZM6CPFAQXFGXOGOHOFIODTCERSHA5CNFSM4E5HXCY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOF4XQSQA.gif

Thanks for your quick reply. For location info what I should put there ?

[ustoopia]

I’m not sure what you’re asking. Location info??

[KevinZhanggg]

I’m not sure what you’re asking. Location info??

Oh. Sorry for confusing you. You said need to edit the config file and RTMP part and locations and such. I am asking what locations I should put there. Thanks !

[ustoopia]

Locations like where HLS stores its temporary files or where recorded files will be stored.