Ng2-charts: Update peer dependency to RC 7

Created on 14 Sep 2016  Â·  14Comments  Â·  Source: valor-software/ng2-charts

Since RC 7 is out, the peer dependency should to updated to avoid below warnings:

[email protected] requires a peer of @angular/[email protected] but none was installed.

Most helpful comment

Will be updated to final today

On Tue, Sep 20, 2016, 15:47 Will Vincent [email protected] wrote:

@valorkin https://github.com/valorkin / @natali-abyss
https://github.com/natali-abyss -- Please prioritize updating peer
dependency to the full angular 2.0.0 release. I cannot update my current
codebase because this module causes build failure due to it's now outdated
peer dependencies.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/valor-software/ng2-charts/issues/401#issuecomment-248290947,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDk43RdHacCRDtbragmFjGW_uWKj99Rks5qr9XJgaJpZM4J8p6Z
.

All 14 comments

@naveedahmed1 nice reason for small PR :)

is there any way to force-install it in the meantime? I'm still fairly newish to the npm world and I'm being blocked by:

npm ERR! peerinvalid The package @angular/[email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer @angular/[email protected] wants @angular/common@^2.0.0-rc.4
npm ERR! peerinvalid Peer @angular/[email protected] wants @angular/common@^2.0.0-rc.7
npm ERR! peerinvalid Peer @angular/[email protected] wants @angular/common@^2.0.0-rc.7
npm ERR! peerinvalid Peer @angular/[email protected] wants @angular/common@^2.0.0-rc
npm ERR! peerinvalid Peer [email protected] wants @angular/common@^2.0.0-rc.3
npm ERR! peerinvalid Peer [email protected] wants @angular/[email protected]

With npm 3 you can ignore peer dependencies errors, they actually optional

Well, I gave that a go and it didn't work. They're don't appear to be optional

Angular 2 final is out now.

Looking to use with Angular 2.0.0! Update would be super slick! I am getting blocked by

npm ERR! peerinvalid Peer [email protected] wants @angular/[email protected]

@lhalver1 I'm looking forward to the official update to ng2-charts too, but you should still be able to use the current version (v1.2.0) with Angular 2.0.0 (final release). I get the same errors you see when running npm install, but it still works.

I've used nvm to choose the version of node/npm that I'm using and was able to use both node v6.5.0/npm v3.10.3 as well as node v4.4.4/npm v2.15.1 successfully to install ng2-charts along side Angular 2.0.0.

@jbgarr Thanks dude! Sure enough that is right, get the error but it still works for me when running Angular 2.0 (final).

It only 'still works' if you _already_ had everything installed from rc6. However, if you are installing fresh (for example, a travis automated test/deploy scenario) it'll fail. So this isn't really a small annoyance, this is an urgent update that must happen before you can safely, reliably, migrate to the final angular 2.0.0 release.

I believe PR #411 should resolve the issue.

@valorkin / @natali-abyss -- Please prioritize updating peer dependency to the full angular 2.0.0 release. I cannot update my current codebase because this module causes build failure due to it's now outdated peer dependencies.

Will be updated to final today

On Tue, Sep 20, 2016, 15:47 Will Vincent [email protected] wrote:

@valorkin https://github.com/valorkin / @natali-abyss
https://github.com/natali-abyss -- Please prioritize updating peer
dependency to the full angular 2.0.0 release. I cannot update my current
codebase because this module causes build failure due to it's now outdated
peer dependencies.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/valor-software/ng2-charts/issues/401#issuecomment-248290947,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDk43RdHacCRDtbragmFjGW_uWKj99Rks5qr9XJgaJpZM4J8p6Z
.

@valorkin I didn't see an update happen yesterday.. have a new ETA when we can expect it? :)

@willvincent Looks like it got updated

Yeap, it was :) I always writing to twitter about updates, tomorrow will be
filtering and closing issues. Now I am going to sleep :)

On Wed, Sep 21, 2016, 23:56 lhalver1 [email protected] wrote:

@willvincent https://github.com/willvincent Looks like it got updated
https://github.com/valor-software/ng2-charts/blob/development/package.json#L48

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/valor-software/ng2-charts/issues/401#issuecomment-248740405,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDk43NVSMVnkwAnrDBsZeRutcBg5bl5ks5qsZnxgaJpZM4J8p6Z
.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vmironovs picture vmironovs  Â·  3Comments

martinpinto picture martinpinto  Â·  3Comments

tssobe picture tssobe  Â·  4Comments

dslima90 picture dslima90  Â·  3Comments

RKornu picture RKornu  Â·  3Comments