Ng2-charts: Update library to work with angular2 rc version?

Created on 9 May 2016  Â·  14Comments  Â·  Source: valor-software/ng2-charts

Hello,

When we can expect update of the library to work with angular2 RC version?

Since angular2 libraries are loaded from '@angular/...', i am receiving error:

Thanks in advance.

Most helpful comment

updating lib to rc.1 and charts 2

All 14 comments

+1

rc1 is nice, but even beta17 would be appreciated.

+1

Obviously this would be great, but without underestimating the work required, is there a timeline for this?

Is the goal to do like ng2-bootstrap and also rename to components to correspond to angular2 naming conventions?

+1

+1

updating lib to rc.1 and charts 2

@valorkin I guess the docs and readme are still pending to update?

@valorkin Oh i see, you are still working on it within a branch, btw how do you know which parts of @angular will you need? i see you use :

  "peerDependencies": {
    "@angular/core": "^2.0.0-rc.1",
    "@angular/common": "^2.0.0-rc.1"
  },
  "devDependencies": {
    "@angular/common": "2.0.0-rc.1",
    "@angular/compiler": "2.0.0-rc.1",
    "@angular/core": "2.0.0-rc.1",
    "@angular/platform-browser": "2.0.0-rc.1",
    "@angular/platform-browser-dynamic": "2.0.0-rc.1"
  }

how do you know you need those 4 in dev and only core and common as peer deps in the dist?

By import statement in directive (peer dependencies) and demo app imports (
dev dependencies )

On Fri, May 13, 2016, 19:06 Carlos Esteban Lopez Jaramillo <
[email protected]> wrote:

@valorkin https://github.com/valorkin Oh i see, you are still working
on it within a branch, btw how do you know which parts of @angular
https://github.com/angular will you need? i see you use :

"peerDependencies": {
"@angular/core": "^2.0.0-rc.1",
"@angular/common": "^2.0.0-rc.1"
},
"devDependencies": {
"@angular/common": "2.0.0-rc.1",
"@angular/compiler": "2.0.0-rc.1",
"@angular/core": "2.0.0-rc.1",
"@angular/platform-browser": "2.0.0-rc.1",
"@angular/platform-browser-dynamic": "2.0.0-rc.1"
}

how do you know you need those 4 in dev and only core and common as peer
deps in the dist?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/valor-software/ng2-charts/issues/186#issuecomment-219087392

I meant how do you know your directive needs core and common, where in the docs you find what each includes?

+1

It is not in docs, it is in peer dependencies. So it will explicitly say to
you on install

On Sun, May 15, 2016, 17:28 robertBrem [email protected] wrote:

+1

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/valor-software/ng2-charts/issues/186#issuecomment-219288947

updated to rc.1 and chart.js 2
and published to npm
Re tweets are much appreciated :)
https://twitter.com/valorkin/status/732568221598027776

Was this page helpful?
0 / 5 - 0 ratings

Related issues

grahammutter picture grahammutter  Â·  4Comments

vmironovs picture vmironovs  Â·  3Comments

hggeorgiev picture hggeorgiev  Â·  4Comments

martinpinto picture martinpinto  Â·  3Comments

shenriksen4 picture shenriksen4  Â·  3Comments