Ng-zorro-antd: Adding support for RTL
What problem does this feature solve?
Currently i tried to add RTL support for temporary solution till ant.design release official support for the components. please feel free to check my modified fork
https://github.com/KhaledSMQ/ng-zorro-antd
What does the proposed API look like?
Add RTL Components
KhaledSMQ
All 10 comments
KhaledSMQ
on 30 Jun 2018
+1
mehdiraized
on 29 Dec 2018
Is there any update ?
@vthinkxie
ImMo3
on 27 Apr 2019
+
CoderBees245
on 21 Jul 2019
Currently we are working on a RTL fork of this repository in our company and we made some of components work with right-to-left direction.
I want to contribute and i don't know how to start.
I've already read the Guide.
We add rtl styles to components one by one and at the beginning i want to pull request button component.
Do i need to open an issue per component?
saeedrahimi
on 30 Jul 2019
Hi @saeedrahimi
I saw your pr https://github.com/NG-ZORRO/ng-zorro-antd/pull/3882/files great job
There are two things we must take into consideration
- all styles file are following ant design repo
there is a discuss here and here - we replace moment with date-fns since version 0.7.x because moment is not treeshake-able
maybe you can submit a pr to ant-design repo first, so we can sync from them.
thanks a lot!
vthinkxie
on 30 Jul 2019
@saeedrahimi I noticed that you finished the work of https://github.com/ant-design/ant-design/pull/19380. Great job! Could you please bring RTL to zorro? Many thanks in advance!
wendellhu95
on 3 Jan 2020
@saeedrahimi I noticed that you finished the work of ant-design/ant-design#19380. Great job! Could you please bring RTL to zorro? Many thanks in advance!
RTL of Ant Design in react will be shipping out with v4 release. I there any plan to sync with new release? there are a lot of changes.
I think it needs to discuss after v4 release and syncing zorro with v4.
saeedrahimi
on 3 Jan 2020
@saeedrahimi We're working on ng-zorro-antd 9.0.0 and will sync antd 4.0.0 in this version. So feel free to submit PR.
wendellhu95
on 3 Jan 2020
4704
saeedrahimi
on 20 Jan 2020
Related issues
IonelLupu
路
3Comments
linjianhong
路
3Comments
vthinkxie
路
3Comments
ismezy
路
3Comments
bambooj
路
4Comments
Most helpful comment
Currently we are working on a RTL fork of this repository in our company and we made some of components work with right-to-left direction.
I want to contribute and i don't know how to start.
I've already read the Guide.
We add rtl styles to components one by one and at the beginning i want to pull request button component.
Do i need to open an issue per component?