Nextcloud-deck: Allow archiving cards from filtered results only

[aproposnix]

Describe the solution you'd like
I would like to be able to filter my cards based on tags and to archive only the cards in that filtered view.

1. User applies filter for Tag X
2. User Sees filtered Results with only cards containing the tag 'X'.
3. User selects "Archive Cards" from the menu
4. All cards with the tag 'X' in that column are archived
5. user removes filter
6. All cards without the tag 'X' are still visible in the column

Describe alternatives you've considered
I would have to manually archive each individual card

Additional context

I use the archiving feature quite a bit. I find it useful esp., for sleeping backlog items as well as finished items. This would just make the management of cards a little easier.

[desperateCoder]

I guess the stack / list should be irrelevant, right? After the filter is applied, you want to globally archive all cards currently shown for the current board, did i get this right?

Since this is a UX-topic, I don't have any opinion on my own to this, let's see what @stefan-niedermann says.

[aproposnix]

I guess the stack / list should be irrelevant, right? After the filter is applied, you want to globally archive all cards currently shown for the current board, did i get this right?

Well, that's a good question. I would assume it would be for the current stack only - just like it is now for when I select to archive the cards in the stack.

[desperateCoder]

Just looked that up, the current implementation does not take the filter into account, since the UI tells me "archive all cards in stack XY". A quite simple fix for that would be, that the UI iterates over the shown cards in case the filter is applied and archives each card individually, wouldn't be that hard to build I guess (@stefan-niedermann?).

The other way - archiving all cards in all stacks - would be a little bit more complicated, but also not that hard. I'd wait for @stefan-niedermann to respond, but he's quite busy these days, so please be patient. I'm just the backend dude, my opinion is wrong per default 😆

[stefan-niedermann]

archiving all cards in all stacks - would be a little bit more complicated, but also not that ha

No, this action is always in the context of the current list. It should never archive cards from other lists.

When we "Archive cards", we know in the UI the current Filterinformation. We should pass it down to the archive method of the SyncManager - no need to iterate the visible cards.

@desperateCoder you can already prepare the called method (just copy it and add theFilterinformation to the arguments list). I will then adjust the UI.

[desperateCoder]

@stefan-niedermann To get this straight: you'll give me FilterInformation and a stackId, and I am supposed to delete alle filter results for the specified stack, not all matches of the 'FilterInformation', right?

Thumb up for "thats right", otherwise correct me.

[stefan-niedermann]

Yes, except one detail:

delete alle filter results

Not delete but archive.

[stefan-niedermann]

@desperateCoder see SyncManager#archiveCardsInStack - it now gets the FilterInformation object. Do something with it :)

[stefan-niedermann]

Fixed & will be shipped with 1.11.0.

Only the visible cards of the list will be archived now (If you have an active filter, only those cards which are left will get archived instead of all).

[aproposnix]

@stefan-niedermann I was offered an updated version on play today (it says version 1.10 but it's from the beta channel). After installing it, the filtering is broken as I am not able to select them from the list. I'm not sure if it's caused by this ticket or not.

[desperateCoder]

@aproposnix sorry if that's a dumb question, but as I was testing the feature it took me a few seconds to realize, that the labels aren't clickable, I needed to tap on the row, but right to the label. Is that maybe your problem? @stefan-niedermann is this as-designed?

[aproposnix]

@desperateCoder Yup, that's the issue. If I click to the right of the bubble it works... I am left handed so my thumb doesn't land there. Should I create a ticket?

[desperateCoder]

Ok, so apparently sometimes it's the little things 😅

Should I create a ticket?

That'd be great, thanks!

[stefan-niedermann]

Yeah, please open a separate issue - i already noticed it (it was also the case in the last version), but with an issue it's easier to keep it in mind :)

[aproposnix]

Just one more thing... just to be clear, does the current beta from the play store have this fix applied already?

[desperateCoder]

I just looked up the commit history of the 1.10 tag and nope, sorry, tagged is tagged. But it will be shipped at 1.11, just as @stefan-niedermann promised. Maybe he's a generous guy and tag it soon 😉

[aproposnix]

Just tested this and it's awesome. Thanks for the great work!

[desperateCoder]

Oh wow, you already got an update?! Thought fdroid takes quite a while... 🤷‍♂️

We're glad you like it, you're welcome! Thanks for all your input!

[aproposnix]

Oh wow, you already got an update?! Thought fdroid takes quite a while... man_shrugging

No, I'm still on the Google Play version mostly because I want the latest ASAP :)

[desperateCoder]

@aproposnix oh, you mean the buggy ones? 🤣

Thanks for your patience and contributions, and for not just complaining about everything, but helping to get it fixed. You deserve a damn medal for that!