Next.js: Duplicate <meta name="viewport"> if the custom one is defined in _document.js
Bug report
I recently upgraded to the latest canary and noticed horizontal scrolling on some mobile devices. As it turned out, this was caused by #6754 (cc @developit).
Although the default new value of viewport is inserted only when there is no custom one, this logic did not work for me, because my custom viewport tag was in _document.js and not inside <Head />.
<meta name="viewport" content="width=device-width" />
Moving the tag into <Head /> solved the issue, but it took a while to investigate.
Expected behavior
It'd be great if Next.js searched for <meta name="viewport" content="..." /> inside custom _document.js and either did not insert the default one or asked developers to move their tag into <Head />. WDYT folks?
System information
- Version of Next.js: 8.0.5-canary.17
kachkaev
All 19 comments
same issue on 8.0.4
I was trying to set viewport-fit=cover in the viewport meta tag in _document.js, but it was overridden by the default tag.
I believe it will be a better approach if the viewport meta is already set in _document.js, the default tag shouldn't be added
tkhg
on 12 Apr 2019
Anybody see this question？
smackgg
on 12 Apr 2019
Our team ran into this problem as well and ended up moving our <meta viewport...> tag from _document.js and into _app.js. In _app.js, we are importing Head from 'next/head'; which seems to remove the duplicate, whereas _document.js is importing { Head } from 'next/document';, which did not remove the duplicate.
_app.js seems like an appropriate place to put a global <meta viewport...> tag since it's not SSR related anyway.
lisamartin00
on 16 Apr 2019
So the approach at the moment is to use _app instead of _document?
cesarvarela
on 17 Apr 2019
@cesarvarela yes that is our approach at the moment and does seem to be working..but if anyone has any other suggestions or best practices, we'd love to hear them!
lisamartin00
on 17 Apr 2019
@timneutkens should I make PR to rise a warning in production mode like for the title
nblthree
on 24 Apr 2019
In my case, whenever i use "key" property on , unwanted duplicated meta tag appears like below. even in _app.js
<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1" class="next-head">
cheeki
on 25 Apr 2019
@cheeki I made a PR to fix that but logically there is no need to use the key property on meta tags (But I am not sure, maybe there is a need because I remember that like there was a situation in which key is necessary)
nblthree
on 25 Apr 2019
key is needed if you have a child component rewriting the father's component "head".
_app:
<meta key="meta_description" name="description" content="general description"/>
ChildPage:
<meta key="meta_description" name="description" content="page description"/>
vzaidman
on 28 Apr 2019
I would like to confirm the Expected behavior so that I can solve this one as soon as possible
- If there is a
viewportin_documentdon't add the default one - If there is a
viewportin_documentand another in apageand they don't have the samekeyvalue add both of them - If there is a
viewportin_documentand another in apageand they do have the samekeyvalue add the one in thepage
nblthree
on 1 May 2019
I think it's correct.
but also notice viewport might be in _app as well.
possible in all of them:
in _document in _app and in page
vzaidman
on 1 May 2019
If there is a
viewportin_documentand another in apageand they do have the samekeyvalue add the one in thepage
@vzaidman what if they don't have a key value? I am considering it to be the same as the above
nblthree
on 1 May 2019
@cheeki
In my case, whenever i use "key" property on , unwanted duplicated meta tag appears like below. even in
_app.js<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1" class="next-head">
I think that it's the right behavior check @vzaidman https://github.com/zeit/next.js/issues/6919#issuecomment-487374749 so if you want to overwrite the default meta you shouldn't use the key
nblthree
on 1 May 2019
The expected behavior:
every meta component without "key" is added to the head.
every meta component with key overrides all the other meta components with the same key so only one is added to the head. the overrides will happen in the following order:
- page - most important (most specific)
- _app
- _document - least important (most general)
good to have:
- console.warn about the possibility to add "key" in development if two meta headers with the same name exists.
vzaidman
on 2 May 2019
I think I'm seeing the same issue with
<meta charSet='utf-8' />
Janpot
on 4 May 2019
Hi! After careful review we've decided this is the intended behavior. Head elements that are expected to be deduped should be added using next/head.
The reason this surfaced is because we started defaulting a more commonly used <meta> tag -- not that something is working unexpectedly.
The correct solution in this scenario is to move to using _app over _document.
Timer
on 10 Jun 2019
It might help to mention this in the documentation https://nextjs.org/docs#custom-document
Soundvessel
on 28 Jun 2019
Feel free to send a PR, @Soundvessel!
Timer
on 1 Jul 2019
Head elements that are expected to be deduped should be added using next/head
A downside of this approach is whenever you need some npm package to build global <meta>s which are always the same (e.g. mobile-detect package to add <meta name="viewport"> conditionally) you're forced to include it on both server and client side.
Even though the package is actually needed only once in _document on server side (as this type of <meta>s don't need to be re-rendered in _app).
samilyak
on 8 Aug 2019
Related issues
dunika
·
58Comments
poyiding
·
73Comments
Timer
·
60Comments
baldurh
·
74Comments
acanimal
·
74Comments
Most helpful comment
I would like to confirm the Expected behavior so that I can solve this one as soon as possible
viewportin_documentdon't add the default oneviewportin_documentand another in apageand they don't have the samekeyvalue add both of themviewportin_documentand another in apageand they do have the samekeyvalue add the one in thepage