Next.js: Missing deps in package.json

[vjpr]

Bug report

Describe the bug

Module not found: Error: Can't resolve 'react-is' in '/xxx/node_modules/.registry.npmjs.org/next-server/8.0.4-canary.9/node_modules/next-server/dist/lib/router'

Also @babel/runtime-corejs2 in next-server.

To Reproduce

Occurs when using pnpm which expects explicit deps (no hoisting).

Expected behavior

Screenshots

System information

• OS: [e.g. macOS, Windows]
• Browser (if applies) [e.g. chrome, safari]
• Version of Next.js: [e.g. 6.0.2] 8.0.4-canary.9

Additional context

Workaround

Install deps in app root.

[nathfreder]

This isn't an issue with Next.js

[vjpr]

This isn't an issue with Next.js

Yes it is. Something is being required that is not specified in the closest package.json. This is non-standard, and could cause many issues later on. It also won't support yarn pnp.

[Yzrsah]

edit: Will update for proper version

[Yzrsah]

ESLint project recommended these:

https://github.com/mysticatea/eslint-plugin-node

node/no-extraneous-import | disallow import declarations of extraneous packages |  
-- | -- | --
node/no-extraneous-require | disallow require() expressions of extraneous packages | ⭐️
node/no-missing-import | disallow import declarations of missing files |  
node/no-missing-require | disallow require() expressions of missing files

[timneutkens]

Afaik this was fixed.